third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html - Issue 2694903007: Add a warning for the deprecation of content-initiated data URL navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

Issue 2694903007: Add a warning for the deprecation of content-initiated data URL navigations (Closed)

Patch Set: creis comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/adopt-node-crash.html ('k') | third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

diff --git a/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html b/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

index 7958ad5f809b987d59b9e13885e0511b3ee56684..01ceb7465ebaa3165548b4f537e76a4a0223c0a5 100644

--- a/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

+++ b/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

@@ -24,8 +24,7 @@ function test() {

// This function will be called when plugin receives a mousedown event.

function popup_by_mousedown() {

- // Open a new window.

- window.open("data:text/html\, open new window by mouse down", "_blank");

+ window.open("about:blank", "_blank");

// Check the new opened window and logging the result.

console.log("window count: " + window.testRunner.windowCount());

if (window.testRunner.windowCount() == (window.windowCount + 1)) {

@@ -47,7 +46,7 @@ function send_key_to_plugin() {

// This function will be called when plugin receives a keydown event.

function popup_by_keydown() {

// Open a new window.

- window.open("data:text/html\, open new window by key down", "_blank");

+ window.open("about:blank", "_blank");

// Check the new opened window and logging the result.

console.log("window count: " + window.testRunner.windowCount());

if (window.testRunner.windowCount() == (window.windowCount + 1))