Index: chrome/common/pref_names.cc |
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc |
index b667f6f51c6554448b779e1d8d9f78388275db6e..24f7293eb743eff09b6514019bd6c3c5cb8c0312 100644 |
--- a/chrome/common/pref_names.cc |
+++ b/chrome/common/pref_names.cc |
@@ -2395,6 +2395,22 @@ const char kIOSPromotionEligible[] = "ios.desktoptomobileeligible"; |
// SMS. |
const char kIOSPromotionDone[] = "ios.desktop_ios_promo_done"; |
sky
2017/02/17 00:57:23
When is this used? I see you check it, but never a
mrefaat
2017/02/17 04:31:50
The value is changed on the iOS client when the us
sky
2017/02/17 19:06:27
Please update the comment to better indicate this.
mrefaat
2017/02/17 21:53:14
Done.
|
+// Index of the entry point that last initiated sending the SMS to the user for |
+// the "desktop to iOS" promotion (see DesktopIOSPromotion.IOSSigninReason |
+// histogram for details). |
+const char kIOSPromotionSMSEntryPoint[] = |
+ "ios.desktop_ios_promo_sms_entrypoint"; |
+ |
+// Indexes of all the entry points presented to the user for "desktop to iOS" |
sky
2017/02/17 00:57:23
Isn't this a bitmask? Please update comment accord
mrefaat
2017/02/17 04:31:50
Done.
|
+// promotion |
+const char kIOSPromotionShownEntryPoints[] = |
+ "ios.desktop_ios_promo_shown_entrypoints"; |
+ |
+// Timestamp of the last "desktop to iOS" promotion last impression, |
+// This is the same time of SMS sending if the user optin to send SMS. |
sky
2017/02/17 00:57:23
Is this second part really true? I see you set it
mrefaat
2017/02/17 04:31:50
Yes but once the user click SMS then this will not
sky
2017/02/17 19:06:29
Don't you set the value on initial show which is n
mrefaat
2017/02/17 21:53:14
we only care about the day. so it may be off by co
sky
2017/02/17 22:49:32
Sure, but the comment doesn't indicate this. Pleas
mrefaat
2017/02/18 00:03:25
Acknowledged.
|
+const char kIOSPromotionLastImpression[] = |
+ "ios.desktop_ios_promo_last_impression"; |
+ |
// Number of times user has seen the "desktop to iOS" save passwords bubble |
// promotion. |
const char kNumberSavePasswordsBubbleIOSPromoShown[] = |