Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc |
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc |
index 4979c58621c25bc718e1dfbeb3a0eb90f6bad678..58f89122ab3fb32e087820e800300768d8a1f59e 100644 |
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc |
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc |
@@ -830,8 +830,8 @@ void ManagePasswordsBubbleView::CreateChild() { |
#if defined(OS_WIN) |
} else if (model_.state() == |
password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE) { |
- AddChildView(new DesktopIOSPromotionView( |
- desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE)); |
+ AddChildView( |
sky
2017/02/17 00:57:23
What are the lifetimes here? You have the controll
mrefaat
2017/02/17 04:31:50
The parent view (BubbleView) owns the view. and th
sky
2017/02/17 19:06:26
How does the lifetime of the password ui controlle
mrefaat
2017/02/17 21:53:14
I think moving the controller to the model and mad
sky
2017/02/17 22:49:32
Sorry if I wasn't clear, too many models and contr
mrefaat
2017/02/18 00:03:25
Done.
|
+ static_cast<DesktopIOSPromotionView*>(model_.GetDesktopIOSPromotion())); |
sky
2017/02/17 00:57:23
This cast indicates a problem in your design. If G
mrefaat
2017/02/17 04:31:50
Because we can't have dependency from from the con
sky
2017/02/17 19:06:26
You changed it to create the view directly, which
mrefaat
2017/02/17 21:53:14
Done that
|
#endif |
} else { |
AddChildView(new ManageView(this)); |