Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)
Patch Set: Addressing comments/Update phone number usage/Change view-controller relation/Pending tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h
diff --git a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h
index 65c71080090d20276317dc94031525047678e90a..6c13c4c2d211b3bed4ee9c62342513bcf4d41097 100644
--- a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h
+++ b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h
@@ -6,8 +6,10 @@
#define CHROME_BROWSER_UI_VIEWS_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_VIEW_H_
#include "base/macros.h"
+#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion.h"
#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h"
#include "ui/views/controls/button/button.h"
+#include "ui/views/controls/label.h"
#include "ui/views/view.h"
class DesktopIOSPromotionController;
@@ -16,10 +18,14 @@ class DesktopIOSPromotionController;
// desktop to ios promotion view.
// This view will always be created as a subview of an existing
// bubble (ie. Password Bubble, Bookmark Bubble).
-class DesktopIOSPromotionView : public views::View,
+class DesktopIOSPromotionView : public DesktopIOSPromotion,
+ public views::View,
public views::ButtonListener {
public:
- explicit DesktopIOSPromotionView(desktop_ios_promotion::PromotionEntryPoint);
+ explicit DesktopIOSPromotionView(DesktopIOSPromotionController* controller);
+ ~DesktopIOSPromotionView() override;
+
+ void UpdateRecoveryPhoneLabel();
sky 2017/02/17 00:57:23 override, and comment where override comes from, e
mrefaat 2017/02/17 04:31:50 Done.
private:
// ButtonListener:
@@ -27,9 +33,10 @@ class DesktopIOSPromotionView : public views::View,
views::Button* send_sms_button_ = nullptr;
views::Button* no_button_ = nullptr;
- // TODO(crbug.com/676655): Add learn more link.
+ views::Label* recovery_phone_label_ = nullptr;
- DesktopIOSPromotionController* promotion_controller_ = nullptr;
+ // A weak pointer to the controller.
+ DesktopIOSPromotionController* promotion_controller_;
DISALLOW_COPY_AND_ASSIGN(DesktopIOSPromotionView);
};

Powered by Google App Engine
This is Rietveld 408576698