chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 2694893002: Integrate SMS service with Desktop iOS promotion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)

Patch Set: nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index d275afe0dbf23a0fcf6fd4e13205a21149e6cdf5..a5c544e285881fcf7bd27903ea3ddad8dcd77285 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -459,8 +459,6 @@ bool ManagePasswordsBubbleModel::ReplaceToShowPromotionIfNeeded() {

title_ = l10n_util::GetStringUTF16(

IDS_PASSWORD_MANAGER_DESKTOP_TO_IOS_PROMO_TITLE);

state_ = password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE;

- // TODO(crbug.com/676655): Update impression count.

- // TODO(crbug.com/676655): Add required logging.

return true;

}

#endif