Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4479)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)
Patch Set: nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index d275afe0dbf23a0fcf6fd4e13205a21149e6cdf5..a5c544e285881fcf7bd27903ea3ddad8dcd77285 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -459,8 +459,6 @@ bool ManagePasswordsBubbleModel::ReplaceToShowPromotionIfNeeded() {
title_ = l10n_util::GetStringUTF16(
IDS_PASSWORD_MANAGER_DESKTOP_TO_IOS_PROMO_TITLE);
state_ = password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE;
- // TODO(crbug.com/676655): Update impression count.
- // TODO(crbug.com/676655): Add required logging.
return true;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698