Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 9c9f420bbef0707ac92f31ea18e7046caecb0477..ab8237b4cb0e9d5cf8019328a9ad402874b3a1dc 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -10254,6 +10254,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="DesktopIOSPromotion.DismissalReason" |
| + enum="DesktopIOSPromotionDismissalReason"> |
| + <owner>mrefaat@chromium.org</owner> |
| + <summary> |
| + The dimissal reason of the desktop to iOS promotion entry point. |
| + DismissalReason will be prefixed by the entry point promotion name that the |
| + user interacted with. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DesktopIOSPromotion.ImpressionFromEntryPoint" |
| + enum="DesktopIOSPromotionEntryPoint"> |
| + <owner>mrefaat@chromium.org</owner> |
| + <summary> |
| + The type of the desktop to iOS promotion that was shown to the user. This |
| + will be logged every time the user sees the desktop to iOS promotion. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DesktopIOSPromotion.IOSSigninReason" |
| enum="DesktopIOSPromotionEntryPoint"> |
| <owner>mrefaat@chromium.org</owner> |
| @@ -10272,7 +10291,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| enum="BooleanSuccess"> |
| <owner>justincohen@chromium.org</owner> |
| <summary> |
| - Whether getting the OAuth token was successful for a desktop to ios |
| + Whether getting the OAuth token was successful for a desktop to iOS |
| promotion query. |
| </summary> |
| </histogram> |
| @@ -10286,6 +10305,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="DesktopIOSPromotion.QueryPhoneNumberSucceeded" |
| + enum="BooleanSuccess"> |
| + <owner>mrefaat@chromium.org</owner> |
| + <summary> |
| + Whether the SMS service api called from the desktop to iOS promotion |
| + returned the a phone number or failed. This phone number is presented to the |
|
Mark P
2017/02/17 23:41:20
nit: "the a" -> "a"
mrefaat
2017/02/18 00:03:25
Done.
|
| + user so they know that Chrome will send the SMS to this number. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DesktopIOSPromotion.SendSMSSucceeded" enum="BooleanSuccess"> |
| + <owner>mrefaat@chromium.org</owner> |
| + <summary> |
| + Whether the SMS service api initiated SMS sending successfully from the |
| + desktop to iOS promotion. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DesktopIOSPromotion.SMSToSigninTime" units="hours"> |
| <owner>mrefaat@chromium.org</owner> |
| <summary> |
| @@ -10295,7 +10332,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| to the user on the last 7 days and if at least one SMS was sent. If multiple |
| SMSs were sent (at any time), it uses the time from the most recently sent |
| one. If the is negative due to bad clock on one of the clients it will be |
| - logged as 0. CompletionTime will be prefixed by the entry point promotion |
| + logged as 0. SMSToSigninTime will be prefixed by the entry point promotion |
| name that was responsible for the SMS sending. |
| </summary> |
| </histogram> |
| @@ -84911,10 +84948,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="12" label="Tab capturer created without audio capturer."/> |
| </enum> |
| +<enum name="DesktopIOSPromotionDismissalReason" type="int"> |
| + <int value="0" label="Focus lost."/> |
| + <int value="1" label="No thanks clicked."/> |
| + <int value="2" label="Close button clicked."/> |
| + <int value="3" label="Send SMS clicked."/> |
| +</enum> |
| + |
| <enum name="DesktopIOSPromotionEntryPoint" type="int"> |
| <int value="1" label="Save Passwords new bubble."/> |
| <int value="2" label="Bookmarks new bubble."/> |
| - <int value="3" label="Bookmarks existing bubble."/> |
| + <int value="3" label="Bookmarks footnote."/> |
| <int value="4" label="HistoryPage."/> |
| </enum> |
| @@ -97079,6 +97123,7 @@ value. |
| <int value="-1396974542" label="UserMediaScreenCapturing:enabled"/> |
| <int value="-1392562498" label="disable-origin-chip"/> |
| <int value="-1386966873" label="disable-mac-views-native-app-windows"/> |
| + <int value="-1377186702" label="DesktopIOSPromotion:disabled"/> |
| <int value="-1375111024" label="enable-fixed-position-compositing"/> |
| <int value="-1365503870" label="enable-simplified-fullscreen-ui"/> |
| <int value="-1363709707" label="MaterialDesignHistory:disabled"/> |
| @@ -97505,6 +97550,7 @@ value. |
| <int value="546710806" label="disable-easy-signin"/> |
| <int value="550378029" label="reset-app-list-install-state"/> |
| <int value="550387510" label="NTPAssetDownloadSuggestions:disabled"/> |
| + <int value="562979188" label="DesktopIOSPromotion:enabled"/> |
| <int value="567368307" label="enable-experimental-canvas-features"/> |
| <int value="575394365" label="AndroidPaymentApps:disabled"/> |
| <int value="581118445" label="enable-eol-notification"/> |
| @@ -113868,9 +113914,10 @@ value. |
| <histogram_suffixes name="DesktopIOSEntryPoints" separator="." |
| ordering="prefix"> |
| + <affected-histogram name="DesktopIOSPromotion.DismissalReason"/> |
| <suffix name="SavePasswordsNewBubble"/> |
| <suffix name="BookmarksNewBubble"/> |
| - <suffix name="BookmarksExistingBubble"/> |
| + <suffix name="BookmarksFootNote"/> |
| <suffix name="HistoryPage"/> |
| <affected-histogram name="DesktopIOSPromotion.SMSToSigninTime"/> |
| </histogram_suffixes> |