Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)
Patch Set: add desktop_ios_promotion_util unittest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h
diff --git a/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h b/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h
index c167041e9d958f3e1eeac350cf611fdbab3a8c0e..4d5b5a615207e12e155df762f602c0bf438b2ba2 100644
--- a/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h
+++ b/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h
@@ -5,28 +5,71 @@
#ifndef CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_CONTROLLER_H_
#define CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_CONTROLLER_H_
+#include <memory>
+#include <string>
+
#include "base/macros.h"
+#include "chrome/browser/ui/desktop_ios_promotion/sms_service.h"
namespace desktop_ios_promotion {
enum class PromotionEntryPoint;
}
+class DesktopIOSPromotion;
+class Profile;
+class PrefService;
+
// This class provides data to the Desktop to mobile promotion and control the
// promotion actions.
class DesktopIOSPromotionController {
public:
- // Should be instantiated on the UI thread.
- DesktopIOSPromotionController();
+ // Must be instantiated on the UI thread.
+ DesktopIOSPromotionController(
+ Profile* profile,
+ desktop_ios_promotion::PromotionEntryPoint entry_point);
~DesktopIOSPromotionController();
+ // Returns the current promotion entry point.
+ desktop_ios_promotion::PromotionEntryPoint GetEntryPoint();
sky 2017/02/17 19:06:29 Name this entry_point() and inline.
mrefaat 2017/02/17 21:53:14 Done.
+
+ // Called by the promotion view.
+ void SetPromotion(DesktopIOSPromotion* promotion);
sky 2017/02/17 19:06:29 Once you rename DesktopIOSPromotion rename this to
mrefaat 2017/02/17 21:53:14 Done.
+
// Called by the view code when "Send SMS" button is clicked by the user.
void OnSendSMSClicked();
+ // Called by the view code when the promotion is ready to show.
+ void OnPromotionShown();
+
// Called by the view code when "No Thanks" button is clicked by the user.
void OnNoThanksClicked();
- // (TODO): If needed verify that functions that affect the UI are done
- // on the same thread.
+ // Returns the Recovery phone number, returns empy string if the number is not
+ // set.
+ std::string GetUsersRecoveryPhoneNumber();
+
+ private:
+ // Updates the user's recovery phone number once the sms_service phone query
+ // returns a response.
+ void OnGotPhoneNumber(SMSService::Request* request,
+ bool success,
+ const std::string& number);
+
+ // Callback that logs the result when sms_service send sms returns a response.
+ void OnSendSMS(SMSService::Request* request,
+ bool success,
+ const std::string& number);
+
+ PrefService* profile_prefs_;
+ const desktop_ios_promotion::PromotionEntryPoint entry_point_;
+ // Service used to send SMS to the user recovery phone number.
+ SMSService* sms_service_;
+ // User's recovery phone number, this is updated by the sms_service.
+ std::string recovery_number_;
+ // A Weak pointer to the promotion.
sky 2017/02/17 19:06:29 promotion view
mrefaat 2017/02/17 21:53:14 Done.
+ DesktopIOSPromotion* promotion_ = nullptr;
+
+ base::WeakPtrFactory<DesktopIOSPromotionController> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(DesktopIOSPromotionController);
};

Powered by Google App Engine
This is Rietveld 408576698