Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)
Patch Set: passwords and histogram changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index d275afe0dbf23a0fcf6fd4e13205a21149e6cdf5..55e521c1f271122cafcd6ac14da2bd8fd5937e08 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -32,6 +32,8 @@
#include "ui/base/l10n/l10n_util.h"
#if defined(OS_WIN)
+#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion.h"
vasilii 2017/02/17 14:19:37 not needed.
mrefaat 2017/02/17 14:44:47 Done.
+#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h"
#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h"
#endif
@@ -458,9 +460,10 @@ bool ManagePasswordsBubbleModel::ReplaceToShowPromotionIfNeeded() {
title_brand_link_range_ = gfx::Range();
title_ = l10n_util::GetStringUTF16(
IDS_PASSWORD_MANAGER_DESKTOP_TO_IOS_PROMO_TITLE);
+ ios_promotion_controller_.reset(new DesktopIOSPromotionController(
+ GetProfile(),
+ desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE));
state_ = password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE;
- // TODO(crbug.com/676655): Update impression count.
- // TODO(crbug.com/676655): Add required logging.
return true;
}
#endif
@@ -472,6 +475,11 @@ void ManagePasswordsBubbleModel::SetClockForTesting(
interaction_keeper_->SetClockForTesting(std::move(clock));
}
+DesktopIOSPromotionController*
+ManagePasswordsBubbleModel::GetDesktopIOSPromotionController() {
+ return ios_promotion_controller_.get();
+}
+
void ManagePasswordsBubbleModel::UpdatePendingStateTitle() {
title_brand_link_range_ = gfx::Range();
PasswordTitleType type =

Powered by Google App Engine
This is Rietveld 408576698