tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4cca652fabfae2d902a148e39ac0f4e59862de6c..ac6b67a4e2f0ca139f55312e0d5cde8f1faecbaf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10188,6 +10188,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.DismissalReason"
+    enum="DesktopIOSPromotionDismissalReason">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    The user interaction with the desktop to iOS promotion entry point.
+    UserAction be prefixed by the entry point promotion name that the user

[Mark P, 2017/02/16 23:18:57]

UserAction -> DismissalReason ?
also missing word "will"

[mrefaat, 2017/02/17 00:20:59]

Done.

+    interacted with.

[Mark P, 2017/02/16 23:18:57]

Upon lost focus, does the promotion disappear, or can the user come back and
interact with it?

[mrefaat, 2017/02/17 00:20:59]

it disappears

+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.ImpressionFromEntryPoint"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    The type of the desktop to iOS promotion that was shown to the user. This
+    will be logged everytime user sees promotion from any entry point.

[Mark P, 2017/02/16 23:18:57]

Does "from any entry point" add anything?  Do you mean regardless of which they
launch Chrome?  Or from any other devices?  Or ...

You can think about omitting the phrase.

[mrefaat, 2017/02/17 00:20:59]

I'll delete it it adds no meaning

+  </summary>
+</histogram>
+
 <histogram name="DesktopIOSPromotion.IOSSigninReason"
     enum="DesktopIOSPromotionEntryPoint">
   <owner>mrefaat@chromium.org</owner>
@@ -10220,6 +10239,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.QueryPhoneNumberSucceeded"
+    enum="BooleanSuccess">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    Weather querying the recovery phone number for a user for desktop to iOS

[Mark P, 2017/02/16 23:18:57]

nit: Weather -> Whether

also, what does "querying" mean in this description and the histogram name? 
Checking to see if the phone number if valid according to a database?  Sending a
message to it and the message not being blocked as undeliverable?  Having the
user acknowledge that the phone number is theirs?  etc.  Perhaps revise the
histogram name and description for something clearer.

[mrefaat, 2017/02/17 00:20:59]

We query for the phone number to show it the user so they know that when they
click on send sms this will be the number that recieves the sms.

+    promotion was successfull or not.
+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.SendSMSSucceeded" enum="BooleanSuccess">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    Weather sending sms from desktop to iOS promotion was successfull or not.

[Mark P, 2017/02/16 23:18:57]

nit: spelling

This means Google acknowledged it would send the message, right?  It does not
guarantee that the target a valid number and can receive the message, right?

[mrefaat, 2017/02/17 00:20:59]

Yes, we can't know if the user actually received the message but the api return
a success when it initiate the sending.

+  </summary>
+</histogram>
+
 <histogram name="DesktopIOSPromotion.SMSToSigninTime" units="hours">
   <owner>mrefaat@chromium.org</owner>
   <summary>
@@ -10229,7 +10264,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
     to the user on the last 7 days and if at least one SMS was sent. If multiple
     SMSs were sent (at any time), it uses the time from the most recently sent
     one. If the  is negative due to bad clock on one of the clients it will be
-    logged as 0. CompletionTime will be prefixed by the entry point promotion
+    logged as 0. SMSToSigninTime will be prefixed by the entry point promotion
     name that was responsible for the SMS sending.
   </summary>
 </histogram>
@@ -84598,10 +84633,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionDismissalReason" type="int">
+  <int value="0" label="Focus lost."/>
+  <int value="1" label="No thanks clicked."/>
+  <int value="2" label="Close button clicked."/>
+  <int value="3" label="Send SMS clicked."/>
+</enum>
+
 <enum name="DesktopIOSPromotionEntryPoint" type="int">
   <int value="1" label="Save Passwords new bubble."/>
   <int value="2" label="Bookmarks new bubble."/>
-  <int value="3" label="Bookmarks existing bubble."/>

[Mark P, 2017/02/16 23:18:57]

To confirm, this is just clarifying the name/behavior, not changing the behavior
or meaning, right?

[mrefaat, 2017/02/17 00:20:59]

Yes, but this is more obvious name.

+  <int value="3" label="Bookmarks footnote."/>
   <int value="4" label="HistoryPage."/>
 </enum>
 
@@ -96805,6 +96847,7 @@ value.
   <int value="-1396974542" label="UserMediaScreenCapturing:enabled"/>
   <int value="-1392562498" label="disable-origin-chip"/>
   <int value="-1386966873" label="disable-mac-views-native-app-windows"/>
+  <int value="-1377186702" label="DesktopIOSPromotion:disabled"/>
   <int value="-1375111024" label="enable-fixed-position-compositing"/>
   <int value="-1365503870" label="enable-simplified-fullscreen-ui"/>
   <int value="-1363709707" label="MaterialDesignHistory:disabled"/>
@@ -97229,6 +97272,7 @@ value.
   <int value="546710806" label="disable-easy-signin"/>
   <int value="550378029" label="reset-app-list-install-state"/>
   <int value="550387510" label="NTPAssetDownloadSuggestions:disabled"/>
+  <int value="562979188" label="DesktopIOSPromotion:enabled"/>
   <int value="567368307" label="enable-experimental-canvas-features"/>
   <int value="575394365" label="AndroidPaymentApps:disabled"/>
   <int value="581118445" label="enable-eol-notification"/>
@@ -113559,9 +113603,10 @@ value.
 
 <histogram_suffixes name="DesktopIOSEntryPoints" separator="."
     ordering="prefix">
+  <affected-histogram name="DesktopIOSPromotion.DismissalReason"/>
   <suffix name="SavePasswordsNewBubble"/>
   <suffix name="BookmarksNewBubble"/>
-  <suffix name="BookmarksExistingBubble"/>

[Mark P, 2017/02/16 23:18:57]

Do not delete old histograms or old suffixes; instead mark them as obsolete.
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

(exception if they've never be written to.  Is that the case here?)

[mrefaat, 2017/02/17 00:20:59]

They have not been used ever before.

+  <suffix name="BookmarksFootNote"/>
   <suffix name="HistoryPage"/>
   <affected-histogram name="DesktopIOSPromotion.SMSToSigninTime"/>
 </histogram_suffixes>