Integrate SMS service with Desktop iOS promotion

chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h"
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/strings/stringprintf.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_features.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 
 namespace desktop_ios_promotion {
 
 // Default Impression cap. for each entry point.
 const int kEntryPointImpressionCap[] = {2, 2, 5, 10};
 
+const char* kEntrypointHistogramPrefix[] = {
+    "SavePasswordsNewBubble", "BookmarksNewBubble", "BookmarksFootNote",
+    "HistoryPage",
+};
+
 bool IsEligibleForIOSPromotion(
     PrefService* prefs,
     const syncer::SyncService* sync_service,
     desktop_ios_promotion::PromotionEntryPoint entry_point) {
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kForceDesktopIOSPromotion))
+    return true;
+
   // Promotion should only show for english locale.
+  PrefService* local_state = g_browser_process->local_state();
   std::string locale = base::i18n::GetConfiguredLocale();
   if (locale != "en-US" && locale != "en-CA")
     return false;
   if (!base::FeatureList::IsEnabled(features::kDesktopIOSPromotion) ||
       !sync_service || !sync_service->IsSyncAllowed())
     return false;
+
   // TODO(crbug.com/676655): Check if the specific entrypoint is enabled by
   // Finch.
-  bool is_dismissed =
-      prefs->GetBoolean(kEntryPointLocalPrefs[(int)entry_point][1]);
-  int show_count =
-      prefs->GetInteger(kEntryPointLocalPrefs[(int)entry_point][0]);
+  bool is_dismissed = local_state->GetBoolean(
+      kEntryPointLocalPrefs[static_cast<int>(entry_point)][1]);
+  int show_count = local_state->GetInteger(
+      kEntryPointLocalPrefs[static_cast<int>(entry_point)][0]);
   // TODO(crbug.com/676655): Get the impression cap. from Finch and replace the
   // value from the entryPointImpressionCap array.
-  if (is_dismissed || show_count >= kEntryPointImpressionCap[(int)entry_point])
+  if (is_dismissed ||
+      show_count >= kEntryPointImpressionCap[static_cast<int>(entry_point)])
     return false;
+
+  // Don't show the promotion if the user have used any entry point to recieve
+  // SMS on the last 7 days.
+  double last_impression = prefs->GetDouble(prefs::kIOSPromotionLastImpression);
+  int sms_entrypoint = prefs->GetInteger(prefs::kIOSPromotionSMSEntryPoint);
+  base::TimeDelta delta =
+      base::Time::Now() - base::Time::FromDoubleT(last_impression);
+  if (delta.InDays() <= 7 && sms_entrypoint != 0)
+    return false;
+
   bool is_user_eligible = prefs->GetBoolean(prefs::kIOSPromotionEligible);
   bool did_promo_done_before = prefs->GetBoolean(prefs::kIOSPromotionDone);
   return is_user_eligible && !did_promo_done_before;
 }
 
 base::string16 GetPromoBubbleText(
     desktop_ios_promotion::PromotionEntryPoint entry_point) {
   if (entry_point ==
       desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE) {
     return l10n_util::GetStringUTF16(
         IDS_PASSWORD_MANAGER_DESKTOP_TO_IOS_PROMO_TEXT);
   }
   return base::string16();
 }
 
 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kIOSPromotionEligible, false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
   registry->RegisterBooleanPref(
       prefs::kIOSPromotionDone, false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
+  registry->RegisterIntegerPref(
+      prefs::kIOSPromotionSMSEntryPoint, 0,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
+  registry->RegisterIntegerPref(
+      prefs::kIOSPromotionShownEntryPoints, 0,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
+  registry->RegisterDoublePref(
+      prefs::kIOSPromotionLastImpression, 0,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
 }
 
 void RegisterLocalPrefs(PrefRegistrySimple* registry) {
   registry->RegisterIntegerPref(prefs::kNumberSavePasswordsBubbleIOSPromoShown,
                                 0);
   registry->RegisterBooleanPref(prefs::kSavePasswordsBubbleIOSPromoDismissed,
                                 false);
   registry->RegisterIntegerPref(prefs::kNumberBookmarksBubbleIOSPromoShown, 0);
   registry->RegisterBooleanPref(prefs::kBookmarksBubbleIOSPromoDismissed,
                                 false);
   registry->RegisterIntegerPref(prefs::kNumberBookmarksFootNoteIOSPromoShown,
                                 0);
   registry->RegisterBooleanPref(prefs::kBookmarksFootNoteIOSPromoDismissed,
                                 false);
   registry->RegisterIntegerPref(prefs::kNumberHistoryPageIOSPromoShown, 0);
   registry->RegisterBooleanPref(prefs::kHistoryPageIOSPromoDismissed, false);
 }
 
+void LogDismissalReason(PromotionDismissalReason reason,
+                        PromotionEntryPoint entry_point) {
+  base::Histogram::FactoryGet(
+      base::StringPrintf(
+          "DesktopIOSPromotion.%s.DismissalReason",
+          desktop_ios_promotion::kEntrypointHistogramPrefix[static_cast<int>(
+              entry_point)]),
+      1, static_cast<int>(PromotionEntryPoint::ENTRY_POINT_MAX_VALUE),

[sky, 2017/02/17 19:06:29]

I assume 1 is the minimum value, which you are assuming aligns with that of the
enum. You should use a constant to make that clear. Perhaps
ENTRY_POINT_MIN_VALUE = SAVE_PASSWORD_BUBBLE.

[mrefaat, 2017/02/17 21:53:14]

Done.

+      static_cast<int>(PromotionEntryPoint::ENTRY_POINT_MAX_VALUE) + 1,

[sky, 2017/02/17 19:06:29]

Why the +1 here?

[mrefaat, 2017/02/17 21:53:14]

These are the number of buckets should be max_boundry +1 
https://cs.chromium.org/chromium/src/base/metrics/histogram_macros_internal.h...

+      base::HistogramBase::kUmaTargetedHistogramFlag)
+      ->Add(static_cast<int>(reason));
+}
+
 }  // namespace desktop_ios_promotion