chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion.h - Issue 2694893002: Integrate SMS service with Desktop iOS promotion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion.h

Issue 2694893002: Integrate SMS service with Desktop iOS promotion (Closed)

Patch Set: add desktop_ios_promotion_util unittest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h » ('j') | chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_H_

	6 #define CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_H_

	7

	8 // Interface for The Desktop iOS promotion view.

	9 class DesktopIOSPromotion {
	sky 2017/02/17 19:06:29 As mentioned, please rename this to DesktopIOPromo As mentioned, please rename this to DesktopIOPromotionView. You can rename the existing one to DesktopIOPromotionViewViews. mrefaat 2017/02/17 21:53:14 Done. Show quoted text On 2017/02/17 19:06:29, sky wrote: > As mentioned, please rename this to DesktopIOPromotionView. You can rename the > existing one to DesktopIOPromotionViewViews. Done.
	10 public:

	11 virtual void UpdateRecoveryPhoneLabel() = 0;
	sky 2017/02/17 19:06:29 My previous comment about not needing the destruct My previous comment about not needing the destructor was more around = default. Chromium style is to have a virtual destructor. You can either inline or = default, which ever you prefer. mrefaat 2017/02/17 21:53:14 Done. Show quoted text On 2017/02/17 19:06:29, sky wrote: > My previous comment about not needing the destructor was more around = default. > Chromium style is to have a virtual destructor. You can either inline or = > default, which ever you prefer. Done.
	12 };

	13

	14 #endif // CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_H_

OLD	NEW