tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4cca652fabfae2d902a148e39ac0f4e59862de6c..88ad9c98563cb874c270b07c54638076ea67209e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10188,6 +10188,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.DismissalReason"
+    enum="DesktopIOSPromotionDismissalReason">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    The dimissal reason of the desktop to iOS promotion entry point.
+    DismissalReason will be prefixed by the entry point promotion name that the
+    user interacted with.
+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.ImpressionFromEntryPoint"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    The type of the desktop to iOS promotion that was shown to the user. This
+    will be logged everytime user sees desktop to iOS promotion.

[Mark P, 2017/02/17 06:15:28]

nit: I think it should be "every time"
also, add "the" before "user",
and add "the" before "desktop"
(both of these last two are for consistency with the previous sentence; it reads
better)

[mrefaat, 2017/02/17 12:55:17]

Done.

+  </summary>
+</histogram>
+
 <histogram name="DesktopIOSPromotion.IOSSigninReason"
     enum="DesktopIOSPromotionEntryPoint">
   <owner>mrefaat@chromium.org</owner>
@@ -10206,7 +10225,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
     enum="BooleanSuccess">
   <owner>justincohen@chromium.org</owner>
   <summary>
-    Whether getting the OAuth token was successful for a desktop to ios
+    Whether getting the OAuth token was successful for a desktop to iOS
     promotion query.
   </summary>
 </histogram>
@@ -10220,6 +10239,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.QueryPhoneNumberSucceeded"
+    enum="BooleanSuccess">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    Wether querying the recovery phone number for a user for desktop to iOS

[Mark P, 2017/02/17 06:15:28]

nit: add "the" or "a" before desktop

[Mark P, 2017/02/17 06:15:28]

nit: Wether -> Whether
(spelling wrong)

[mrefaat, 2017/02/17 12:55:16]

Done.

[mrefaat, 2017/02/17 12:55:16]

Done.

+    promotion was successfull or not, This phone number is presented to the user

[Mark P, 2017/02/17 06:15:28]

nit: successful
(spelling)

[Mark P, 2017/02/17 06:15:28]

nit: , -> .

[mrefaat, 2017/02/17 12:55:16]

Done.

[mrefaat, 2017/02/17 12:55:16]

Acknowledged.

+    so they know that we Chrome will send SMS to this number.

[Mark P, 2017/02/17 06:15:28]

I still understand.  By "querying the recovery number" means you ask the user to
enter a recovery number?  Or you show the user a recovery number and then ask
for confirmation that it's right?  (If so, does "successful" means the user
confirm its correctness?  That's an odd word choice for that too.)

This description (and possibly histogram name) still needs work.

[Mark P, 2017/02/17 06:15:28]

nit: drop "we"

[mrefaat, 2017/02/17 12:55:16]

I changed the description a bit, We use the QueryPhone number service call to
get a phone number that we present to the user. we don't get a confirmation from
the user if the number is correct or not. we only present it so the user knows
the number that will receive the SMS.

[mrefaat, 2017/02/17 12:55:16]

Done.

+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.SendSMSSucceeded" enum="BooleanSuccess">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    Wether the SMS service api iniatiated SMS sending successfully from desktop

[Mark P, 2017/02/17 06:15:28]

nit: add "the" or "a" before desktop

[Mark P, 2017/02/17 06:15:28]

nit: two spelling errors in this line

[mrefaat, 2017/02/17 12:55:16]

Done.

[mrefaat, 2017/02/17 12:55:16]

Done.

+    to iOS promotion
+  </summary>
+</histogram>
+
 <histogram name="DesktopIOSPromotion.SMSToSigninTime" units="hours">
   <owner>mrefaat@chromium.org</owner>
   <summary>
@@ -10229,7 +10266,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
     to the user on the last 7 days and if at least one SMS was sent. If multiple
     SMSs were sent (at any time), it uses the time from the most recently sent
     one. If the  is negative due to bad clock on one of the clients it will be
-    logged as 0. CompletionTime will be prefixed by the entry point promotion
+    logged as 0. SMSToSigninTime will be prefixed by the entry point promotion
     name that was responsible for the SMS sending.
   </summary>
 </histogram>
@@ -84598,10 +84635,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionDismissalReason" type="int">
+  <int value="0" label="Focus lost."/>
+  <int value="1" label="No thanks clicked."/>
+  <int value="2" label="Close button clicked."/>
+  <int value="3" label="Send SMS clicked."/>
+</enum>
+
 <enum name="DesktopIOSPromotionEntryPoint" type="int">
   <int value="1" label="Save Passwords new bubble."/>
   <int value="2" label="Bookmarks new bubble."/>
-  <int value="3" label="Bookmarks existing bubble."/>
+  <int value="3" label="Bookmarks footnote."/>
   <int value="4" label="HistoryPage."/>
 </enum>
 
@@ -96805,6 +96849,7 @@ value.
   <int value="-1396974542" label="UserMediaScreenCapturing:enabled"/>
   <int value="-1392562498" label="disable-origin-chip"/>
   <int value="-1386966873" label="disable-mac-views-native-app-windows"/>
+  <int value="-1377186702" label="DesktopIOSPromotion:disabled"/>
   <int value="-1375111024" label="enable-fixed-position-compositing"/>
   <int value="-1365503870" label="enable-simplified-fullscreen-ui"/>
   <int value="-1363709707" label="MaterialDesignHistory:disabled"/>
@@ -97229,6 +97274,7 @@ value.
   <int value="546710806" label="disable-easy-signin"/>
   <int value="550378029" label="reset-app-list-install-state"/>
   <int value="550387510" label="NTPAssetDownloadSuggestions:disabled"/>
+  <int value="562979188" label="DesktopIOSPromotion:enabled"/>
   <int value="567368307" label="enable-experimental-canvas-features"/>
   <int value="575394365" label="AndroidPaymentApps:disabled"/>
   <int value="581118445" label="enable-eol-notification"/>
@@ -113559,9 +113605,10 @@ value.
 
 <histogram_suffixes name="DesktopIOSEntryPoints" separator="."
     ordering="prefix">
+  <affected-histogram name="DesktopIOSPromotion.DismissalReason"/>
   <suffix name="SavePasswordsNewBubble"/>
   <suffix name="BookmarksNewBubble"/>
-  <suffix name="BookmarksExistingBubble"/>
+  <suffix name="BookmarksFootNote"/>
   <suffix name="HistoryPage"/>
   <affected-histogram name="DesktopIOSPromotion.SMSToSigninTime"/>
 </histogram_suffixes>