Integrate SMS service with Desktop iOS promotion

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 11 matching lines @@
 }
 
 namespace password_manager {
 enum class CredentialType;
 struct InteractionsStats;
 class PasswordFormManager;
 }
 
 class AccountChooserPrompt;
 class AutoSigninFirstRunPrompt;
+class DesktopIOSPromotion;
+class DesktopIOSPromotionController;
 class ManagePasswordsIconView;
 class PasswordDialogController;
 class PasswordDialogControllerImpl;
 
 // Per-tab class to control the Omnibox password icon and bubble.
 class ManagePasswordsUIController
     : public content::WebContentsObserver,
       public content::WebContentsUserData<ManagePasswordsUIController>,
       public password_manager::PasswordStore::Observer,
       public PasswordsModelDelegate,
@@ skipping 53 matching lines @@
   void OnBubbleShown() override;
   void OnBubbleHidden() override;
   void OnNoInteraction() override;
   void OnNopeUpdateClicked() override;
   void NeverSavePassword() override;
   void SavePassword() override;
   void UpdatePassword(const autofill::PasswordForm& password_form) override;
   void ChooseCredential(
       const autofill::PasswordForm& form,
       password_manager::CredentialType credential_type) override;
+  DesktopIOSPromotion* CreateDesktopIOSPromotion() override;
   void NavigateToSmartLockHelpPage() override;
   void NavigateToPasswordManagerSettingsPage() override;
   void NavigateToChromeSignIn() override;
   void OnDialogHidden() override;
 
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // The pieces of saving and blacklisting passwords that interact with
@@ skipping 51 matching lines @@
 
   // content::WebContentsObserver:
   void WebContentsDestroyed() override;
 
   // The wrapper around current state and data.
   ManagePasswordsState passwords_data_;
 
   // The controller for the blocking dialogs.
   std::unique_ptr<PasswordDialogControllerImpl> dialog_controller_;
 
+  // The controller for the desktop ios promotion.
+  std::unique_ptr<DesktopIOSPromotionController> ios_promotion_controller_;

[vasilii, 2017/02/17 12:59:14]

This shouldn't be here. Move it to ManagePasswordsBubbleModel.
ManagePasswordsUIController and PasswordsModelDelegate should stay intact.

[mrefaat, 2017/02/17 14:13:49]

Done.

+
   BubbleStatus bubble_status_;
 
   // The bubbles of different types can pop up unpredictably superseding each
   // other. However, closing the bubble may affect the state of
   // ManagePasswordsUIController internally. This is undesired if
   // ManagePasswordsUIController is in the process of opening a new bubble. The
   // situation is worse on Windows where the bubble is destroyed asynchronously.
   // Thus, OnBubbleHidden() can be called after the new one is shown. By that
   // time the internal state of ManagePasswordsUIController has nothing to do
   // with the old bubble.
   // Invalidating all the weak pointers will detach the current bubble.
   base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_