Issue 269483002: Get presubmit_support to compute diffs against a given upstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269483002: Get presubmit_support to compute diffs against a given upstream. (Closed)

Created:
6 years, 7 months ago by agable

Modified:
6 years, 7 months ago

Reviewers:
Ryan Tseng, hinoka

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -34 lines)			Patch
M	git_cl.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	presubmit_support.py	View	10 chunks	+19 lines, -14 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	12 chunks	+27 lines, -19 lines	0 comments	Download

Total messages: 5 (0 generated)

Ryan Tseng

Passed when I ran it end-to-end. LGTM on functionality Will do more detailed review later.

6 years, 7 months ago (2014-04-30 19:52:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/269483002/1

6 years, 7 months ago (2014-04-30 19:53:12 UTC) #4

Message was sent while issue was closed.

Change committed as 267309