third_party/WebKit/Source/DEPS - Issue 2694743004: Reset the nesting level for setInterval after completion.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/DEPS

Issue 2694743004: Reset the nesting level for setInterval after completion. (Closed)

Patch Set: Apply review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base/macros.h",	2 "+base/macros.h",

3 "+base/gtest_prod_util.h",	3 "+base/gtest_prod_util.h",

	4 "+gin",
	jochen (gone - plz use gerrit) 2017/02/15 10:35:12 please use macros from Source/bindings/core/v8 ins please use macros from Source/bindings/core/v8 instead Dan Elphick 2017/02/15 14:03:32 I've changed it to use toImplArray from that direc Show quoted text On 2017/02/15 10:35:12, jochen wrote: > please use macros from Source/bindings/core/v8 instead I've changed it to use toImplArray from that directory.
4 "+testing/gmock/include/gmock",	5 "+testing/gmock/include/gmock",

5 "+testing/gtest/include/gtest",	6 "+testing/gtest/include/gtest",

6 "+wtf",	7 "+wtf",

7 ]	8 ]

8	9

	10 specific_include_rules = {

	11 ".*test\.cpp": [

	12 "+gin",

	13 ],

	14 }

	15

9 skip_child_includes = [	16 skip_child_includes = [

10 "testing",	17 "testing",

11 ]	18 ]

OLD	NEW