Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

Issue 2694703006: webkitpy: Fixing tests broken via WontFix change. (Closed)
Patch Set: Fixing assertIn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
index 1a1afae9d94b2da7b65cc6529589621089b58d24..1c9815fd5803a0f6343b0f1d21be88113723373c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
@@ -206,7 +206,7 @@ class SummarizedResultsTest(unittest.TestCase):
'IMAGE': 1,
'NEEDSREBASELINE': 0,
'NEEDSMANUALREBASELINE': 0,
- 'PASS': 1,
+ 'PASS': 0,
'REBASELINE': 0,
'SKIP': 0,
'SLOW': 0,
@@ -215,7 +215,7 @@ class SummarizedResultsTest(unittest.TestCase):
'LEAK': 0,
'FAIL': 0,
'AUDIO': 0,
- 'WONTFIX': 0
+ 'WONTFIX': 1
})
summary = summarized_results(self.port, expected=True, passing=False, flaky=False)
@@ -281,7 +281,7 @@ class SummarizedResultsTest(unittest.TestCase):
def test_summarized_results_wontfix(self):
self.port._options.builder_name = 'dummy builder'
summary = summarized_results(self.port, expected=False, passing=False, flaky=False)
- self.assertEquals(summary['tests']['failures']['expected']['keyboard.html']['expected'], 'CRASH')
+ self.assertEquals(summary['tests']['failures']['expected']['keyboard.html']['expected'], 'WONTFIX CRASH')
self.assertTrue(summary['tests']['passes']['text.html']['is_unexpected'])
self.assertEqual(summary['num_passes'], 1)
self.assertEqual(summary['num_regressions'], 6)
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698