components/password_manager/core/browser/import/csv_reader.cc - Issue 2694693002: Roll re2 dba3349..596d73e.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/import/csv_reader.cc

Issue 2694693002: Roll re2 dba3349..596d73e. (Closed)

Patch Set: Use unsigned literal when asserting re2::StringPiece::size() value. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/import/csv_reader.cc

diff --git a/components/password_manager/core/browser/import/csv_reader.cc b/components/password_manager/core/browser/import/csv_reader.cc

index 49160688e17d8c36debfe3273cc2824c9103b608..957c314055dfab2a5cb34285f9d19edb26cb2489 100644

--- a/components/password_manager/core/browser/import/csv_reader.cc

+++ b/components/password_manager/core/browser/import/csv_reader.cc

@@ -78,7 +78,7 @@ bool CSVParser::ParseNextCSVRow(std::vector<std::string>* fields) {

return false;

if (field.starts_with("\"")) {

CHECK(field.ends_with("\""));

- CHECK_GE(field.size(), 2);

+ CHECK_GE(field.size(), 2u);

field.remove_prefix(1);

field.remove_suffix(1);

}

« no previous file with comments | « DEPS ('k') | testing/libfuzzer/fuzzers/re2_fuzzer.cc » ('j') | no next file with comments »