Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2694653005: Extract BackendUsageBuilder from BackendUsage (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract BackendUsageBuilder from BackendUsage Ideally BackendUsageBuilder should only be used during closed world computation and BackendUsage afterwards. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c5c7fdfea31920a4d1d8a6ad92bbcf229340ce23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -73 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 21 chunks +43 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 7 chunks +65 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 10 months ago (2017-02-14 10:48:01 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-17 22:24:08 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-20 11:21:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5c7fdfea31920a4d1d8a6ad92bbcf229340ce23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698