Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: ash/mus/test/wm_test_helper.cc

Issue 2694623016: chromeos: Makes AshTestBase/Helper target mash when appropriate (Closed)
Patch Set: comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/test/wm_test_helper.cc
diff --git a/ash/mus/test/wm_test_helper.cc b/ash/mus/test/wm_test_helper.cc
index dc94727b60c313fa73f5433223b68c31db23957f..36dbefa8b70943876901437f25214c79bdedf37f 100644
--- a/ash/mus/test/wm_test_helper.cc
+++ b/ash/mus/test/wm_test_helper.cc
@@ -84,6 +84,9 @@ WmTestHelper::~WmTestHelper() {
}
void WmTestHelper::Init() {
+ // General pattern is most places don't uninitialize, so we have to explicitly
msw 2017/02/19 21:49:20 Can you rephrase and clarify this comment? ie. The
sky 2017/02/21 17:06:50 I tried improving the comment. Any better?
msw 2017/02/22 06:25:48 Yes, that makes more sense now.
+ // uninitialize before initializing.
+ ui::test::MaterialDesignControllerTestAPI::Uninitialize();
ui::MaterialDesignController::Initialize();
views_delegate_ = base::MakeUnique<views::TestViewsDelegate>();

Powered by Google App Engine
This is Rietveld 408576698