Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2694623013: Fixed navigation for displayed SSL interstitials. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/interstitials/web_interstitial_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 75805cba2a676f1accfe4bcdb3d4c1ce42882681..7eaeed6a98d275bcba07ca9bb5f9af40ead97b02 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1869,6 +1869,18 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
[webControllerSnapshotHelper_ setSnapshotCoalescingEnabled:NO];
}
+- (void)webState:(web::WebState*)webState
+ didChangeLoadingProgress:(double)progress {
+ // TODO(crbug.com/546406): It is probably possible to do something smarter,
+ // but the fact that this is not always sent will have to be taken into
+ // account.
+ [parentTabModel_ notifyTabChanged:self];
+}
+
+- (void)webStateDidDismissInterstitial:(web::WebState*)webState {
+ [parentTabModel_ notifyTabChanged:self];
+}
+
- (void)webLoadCancelled:(const GURL&)url {
// When a load is cancelled, this is the maximum that a page will ever load.
[fullScreenController_ enableFullScreen];
« no previous file with comments | « no previous file | ios/web/interstitials/web_interstitial_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698