Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2694413006: Scope and clean up uses of AccessibilityMode. (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/accessibility_mode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index dfde98b4901581428049b7540d36d4891e690146..a8e41e567f55932f84b2a92f92e35a867b42b860 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -964,7 +964,9 @@ void WebContentsImpl::SetAccessibilityMode(AccessibilityMode mode) {
}
void WebContentsImpl::AddAccessibilityMode(AccessibilityMode mode) {
- SetAccessibilityMode(accessibility_mode_ | mode);
+ AccessibilityMode new_mode(accessibility_mode_);
+ new_mode |= mode;
+ SetAccessibilityMode(new_mode);
}
void WebContentsImpl::RequestAXTreeSnapshot(AXTreeSnapshotCallback callback) {
@@ -1076,20 +1078,20 @@ const std::string& WebContentsImpl::GetUserAgentOverride() const {
}
void WebContentsImpl::EnableWebContentsOnlyAccessibilityMode() {
- if (GetAccessibilityMode() != AccessibilityModeOff) {
+ if (!GetAccessibilityMode().is_mode_off()) {
for (RenderFrameHost* rfh : GetAllFrames())
ResetAccessibility(rfh);
} else {
- AddAccessibilityMode(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY);
+ AddAccessibilityMode(kAccessibilityModeWebContentsOnly);
}
}
bool WebContentsImpl::IsWebContentsOnlyAccessibilityModeForTesting() const {
- return accessibility_mode_ == ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY;
+ return accessibility_mode_ == kAccessibilityModeWebContentsOnly;
}
bool WebContentsImpl::IsFullAccessibilityModeForTesting() const {
- return accessibility_mode_ == ACCESSIBILITY_MODE_COMPLETE;
+ return accessibility_mode_ == kAccessibilityModeComplete;
}
const PageImportanceSignals& WebContentsImpl::GetPageImportanceSignals() const {
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/accessibility_mode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698