Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2694413006: Scope and clean up uses of AccessibilityMode. (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 20b8dc08d7ae2f78e76803056b96e909facbc8fc..d546edd4bc8407ce0580c7ee3f93a3f2ea582a27 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1978,8 +1978,8 @@ void RenderFrameHostImpl::OnAccessibilityEvents(
RenderWidgetHostViewBase* view = GetViewForAccessibility();
AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- if ((accessibility_mode != AccessibilityModeOff) && view && is_active()) {
- if (accessibility_mode & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS)
+ if (!accessibility_mode.is_mode_off() && view && is_active()) {
+ if (accessibility_mode.has_mode(AccessibilityMode::kNativeAPIs))
GetOrCreateBrowserAccessibilityManager();
std::vector<AXEventNotificationDetails> details;
@@ -2006,7 +2006,7 @@ void RenderFrameHostImpl::OnAccessibilityEvents(
details.push_back(detail);
}
- if (accessibility_mode & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS) {
+ if (accessibility_mode.has_mode(AccessibilityMode::kNativeAPIs)) {
if (browser_accessibility_manager_)
browser_accessibility_manager_->OnAccessibilityEvents(details);
}
@@ -2051,7 +2051,7 @@ void RenderFrameHostImpl::OnAccessibilityLocationChanges(
render_view_host_->GetWidget()->GetView());
if (view && is_active()) {
AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- if (accessibility_mode & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS) {
+ if (accessibility_mode.has_mode(AccessibilityMode::kNativeAPIs)) {
BrowserAccessibilityManager* manager =
GetOrCreateBrowserAccessibilityManager();
if (manager)
@@ -2076,7 +2076,7 @@ void RenderFrameHostImpl::OnAccessibilityLocationChanges(
void RenderFrameHostImpl::OnAccessibilityFindInPageResult(
const AccessibilityHostMsg_FindInPageResultParams& params) {
AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- if (accessibility_mode & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS) {
+ if (accessibility_mode.has_mode(AccessibilityMode::kNativeAPIs)) {
BrowserAccessibilityManager* manager =
GetOrCreateBrowserAccessibilityManager();
if (manager) {
@@ -2946,8 +2946,8 @@ bool RenderFrameHostImpl::IsSameSiteInstance(
}
void RenderFrameHostImpl::UpdateAccessibilityMode() {
- AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- Send(new FrameMsg_SetAccessibilityMode(routing_id_, accessibility_mode));
+ int accessibility_mode_raw = delegate_->GetAccessibilityMode().mode();
+ Send(new FrameMsg_SetAccessibilityMode(routing_id_, accessibility_mode_raw));
}
void RenderFrameHostImpl::RequestAXTreeSnapshot(
@@ -2966,7 +2966,7 @@ void RenderFrameHostImpl::SetAccessibilityCallbackForTesting(
void RenderFrameHostImpl::UpdateAXTreeData() {
AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- if (accessibility_mode == AccessibilityModeOff || !is_active()) {
+ if (accessibility_mode.is_mode_off() || !is_active()) {
return;
}
@@ -3010,7 +3010,7 @@ BrowserAccessibilityManager*
void RenderFrameHostImpl::ActivateFindInPageResultForAccessibility(
int request_id) {
AccessibilityMode accessibility_mode = delegate_->GetAccessibilityMode();
- if (accessibility_mode & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS) {
+ if (accessibility_mode.has_mode(AccessibilityMode::kNativeAPIs)) {
BrowserAccessibilityManager* manager =
GetOrCreateBrowserAccessibilityManager();
if (manager)
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/renderer_host/legacy_render_widget_host_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698