content/renderer/render_view_impl.cc - Issue 2694413006: Scope and clean up uses of AccessibilityMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2694413006: Scope and clean up uses of AccessibilityMode. (Closed)

Patch Set: build bustage Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 65f6b337a9cae51b4f59338f35febd64f5319b6f..367309181387813d9655256f0ebc00e009798b79 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -2504,8 +2504,8 @@ bool RenderViewImpl::didTapMultipleTargets(

AccessibilityMode accessibility_mode =

GetMainRenderFrame()->accessibility_mode();

bool matches_accessibility_mode_complete =

- (accessibility_mode & ACCESSIBILITY_MODE_COMPLETE) ==

- ACCESSIBILITY_MODE_COMPLETE;

+ (accessibility_mode & AccessibilityMode::COMPLETE) ==

dmazzoni 2017/02/17 00:21:50 I think you can simplify this now, just (accessibi

+ AccessibilityMode::COMPLETE;

if (matches_accessibility_mode_complete)

return false;