Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: content/browser/accessibility/accessibility_mode_browsertest.cc

Issue 2694413006: Scope and clean up uses of AccessibilityMode. (Closed)
Patch Set: build bustage Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_mode_browsertest.cc
diff --git a/content/browser/accessibility/accessibility_mode_browsertest.cc b/content/browser/accessibility/accessibility_mode_browsertest.cc
index 610bf85afe5f2f860848e2c79edf1c22b3550607..ff889c5c5825822244082387df48ad36898b730d 100644
--- a/content/browser/accessibility/accessibility_mode_browsertest.cc
+++ b/content/browser/accessibility/accessibility_mode_browsertest.cc
@@ -64,17 +64,17 @@ class AccessibilityModeTest : public ContentBrowserTest {
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeOff) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- EXPECT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
+ EXPECT_EQ(AccessibilityMode::OFF, web_contents()->GetAccessibilityMode());
EXPECT_EQ(nullptr, GetManager());
}
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeComplete) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
+ ASSERT_EQ(AccessibilityMode::OFF, web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(ACCESSIBILITY_MODE_COMPLETE);
- EXPECT_EQ(ACCESSIBILITY_MODE_COMPLETE,
+ web_contents()->AddAccessibilityMode(AccessibilityMode::COMPLETE);
+ EXPECT_EQ(AccessibilityMode::COMPLETE,
web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
EXPECT_NE(nullptr, GetManager());
@@ -83,11 +83,11 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeComplete) {
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest,
AccessibilityModeWebContentsOnly) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
+ ASSERT_EQ(AccessibilityMode::OFF, web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY);
- EXPECT_EQ(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY,
+ web_contents()->AddAccessibilityMode(AccessibilityMode::WEB_CONTENTS_ONLY);
+ EXPECT_EQ(AccessibilityMode::WEB_CONTENTS_ONLY,
web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
// No BrowserAccessibilityManager expected for this mode.
@@ -98,15 +98,15 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddingModes) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY);
- EXPECT_EQ(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY,
+ web_contents()->AddAccessibilityMode(AccessibilityMode::WEB_CONTENTS_ONLY);
+ EXPECT_EQ(AccessibilityMode::WEB_CONTENTS_ONLY,
web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
EXPECT_EQ(nullptr, GetManager());
AccessibilityNotificationWaiter waiter2(shell()->web_contents());
- web_contents()->AddAccessibilityMode(ACCESSIBILITY_MODE_COMPLETE);
- EXPECT_EQ(ACCESSIBILITY_MODE_COMPLETE,
+ web_contents()->AddAccessibilityMode(AccessibilityMode::COMPLETE);
+ EXPECT_EQ(AccessibilityMode::COMPLETE,
web_contents()->GetAccessibilityMode());
waiter2.WaitForNotification();
EXPECT_NE(nullptr, GetManager());
@@ -120,7 +120,7 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest,
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
AccessibilityNotificationWaiter waiter(shell()->web_contents(),
- ACCESSIBILITY_MODE_COMPLETE,
+ AccessibilityMode::COMPLETE,
ui::AX_EVENT_LOAD_COMPLETE);
GURL url("data:text/html,<p>Para</p>");
NavigateToURL(shell(), url);
@@ -144,8 +144,7 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest,
AccessibilityNotificationWaiter waiter(
shell()->web_contents(),
- ACCESSIBILITY_MODE_FLAG_NATIVE_APIS |
- ACCESSIBILITY_MODE_FLAG_WEB_CONTENTS,
+ AccessibilityMode::NATIVE_APIS | AccessibilityMode::WEB_CONTENTS,
ui::AX_EVENT_LOAD_COMPLETE);
GURL url("data:text/html,<p>Para</p>");
NavigateToURL(shell(), url);
@@ -162,8 +161,7 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddScreenReaderModeFlag) {
AccessibilityNotificationWaiter waiter(
shell()->web_contents(),
- ACCESSIBILITY_MODE_FLAG_NATIVE_APIS |
- ACCESSIBILITY_MODE_FLAG_WEB_CONTENTS,
+ AccessibilityMode::NATIVE_APIS | AccessibilityMode::WEB_CONTENTS,
ui::AX_EVENT_LOAD_COMPLETE);
GURL url("data:text/html,<input aria-label=Foo placeholder=Bar>");
NavigateToURL(shell(), url);
@@ -174,10 +172,11 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddScreenReaderModeFlag) {
EXPECT_FALSE(textbox->HasStringAttribute(ui::AX_ATTR_PLACEHOLDER));
int original_id = textbox->GetId();
- AccessibilityNotificationWaiter waiter2(
- shell()->web_contents(), 0, ui::AX_EVENT_LAYOUT_COMPLETE);
+ AccessibilityNotificationWaiter waiter2(shell()->web_contents(),
+ AccessibilityMode::OFF,
+ ui::AX_EVENT_LAYOUT_COMPLETE);
BrowserAccessibilityStateImpl::GetInstance()->AddAccessibilityModeFlags(
- ACCESSIBILITY_MODE_FLAG_SCREEN_READER);
+ AccessibilityMode::SCREEN_READER);
waiter2.WaitForNotification();
const BrowserAccessibility* textbox2 = FindNode(

Powered by Google App Engine
This is Rietveld 408576698