Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2694413006: Scope and clean up uses of AccessibilityMode. (Closed)
Patch Set: remove kOff Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 2daf76a0a060f226895085cd7feedadfe38e5cd6..67ccb2a82d94f6f0dd66a9171dccf76438029311 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -173,6 +173,11 @@ namespace {
const int kMinimumDelayBetweenLoadingUpdatesMS = 100;
const char kDotGoogleDotCom[] = ".google.com";
+const AccessibilityMode kAccessibilityModeWebContent(
+ AccessibilityMode::kWebContents | AccessibilityMode::kInlineTextBoxes |
+ AccessibilityMode::kScreenReader |
+ AccessibilityMode::kHTML);
+
#if defined(OS_ANDROID)
const char kWebContentsAndroidKey[] = "web_contents_android";
#endif // OS_ANDROID
@@ -969,7 +974,9 @@ void WebContentsImpl::SetAccessibilityMode(AccessibilityMode mode) {
}
void WebContentsImpl::AddAccessibilityMode(AccessibilityMode mode) {
- SetAccessibilityMode(accessibility_mode_ | mode);
+ AccessibilityMode new_mode(accessibility_mode_);
+ new_mode |= mode;
+ SetAccessibilityMode(new_mode);
}
void WebContentsImpl::RequestAXTreeSnapshot(AXTreeSnapshotCallback callback) {
@@ -1081,20 +1088,24 @@ const std::string& WebContentsImpl::GetUserAgentOverride() const {
}
void WebContentsImpl::EnableWebContentsOnlyAccessibilityMode() {
- if (GetAccessibilityMode() != AccessibilityModeOff) {
+ if (!GetAccessibilityMode().is_mode_off()) {
for (RenderFrameHost* rfh : GetAllFrames())
ResetAccessibility(rfh);
} else {
- AddAccessibilityMode(ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY);
+ AddAccessibilityMode(kAccessibilityModeWebContent);
}
}
bool WebContentsImpl::IsWebContentsOnlyAccessibilityModeForTesting() const {
- return accessibility_mode_ == ACCESSIBILITY_MODE_WEB_CONTENTS_ONLY;
+ return accessibility_mode_ == kAccessibilityModeWebContent;
}
bool WebContentsImpl::IsFullAccessibilityModeForTesting() const {
- return accessibility_mode_ == ACCESSIBILITY_MODE_COMPLETE;
+ AccessibilityMode complete_mode(
+ AccessibilityMode::kNativeAPIs | AccessibilityMode::kWebContents |
+ AccessibilityMode::kInlineTextBoxes | AccessibilityMode::kScreenReader |
+ AccessibilityMode::kHTML);
+ return accessibility_mode_ == complete_mode;
}
const PageImportanceSignals& WebContentsImpl::GetPageImportanceSignals() const {

Powered by Google App Engine
This is Rietveld 408576698