Issue 2694403003: Add CompilationUnitElement.lineInfo and resynthesize it.

Issue 2694403003: Add CompilationUnitElement.lineInfo and resynthesize it. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add CompilationUnitElement.lineInfo and resynthesize it. One bit that is not quite straight is that UnlinkedUnit.lineInfo is empty. Normally we would have [0] for empty files, which we pretend missing files are. Should we fix this instead of checking in the resynthesizer? R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f47ebbcea3e8c9280ac91e3952b30c1ce12d5bf4

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	pkg/analyzer/lib/dart/element/element.dart	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/element/element.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/element/handle.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Brian Wilkerson

lgtm > Normally we would have [0] for empty files, which we pretend > missing ...

3 years, 10 months ago (2017-02-15 17:41:59 UTC) #3

scheglov

3 years, 10 months ago (2017-02-15 17:54:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f47ebbcea3e8c9280ac91e3952b30c1ce12d5bf4 (presubmit successful).