Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2694403002: Disable testFetchWPRs. (Closed)

Created:
3 years, 10 months ago by achuithb
Modified:
3 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testFetchWPRs. BUG=chromium:692278 TEST=this is the test

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/fetch_benchmark_deps_unittest.py View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (5 generated)
achuithb
Jenny, Ben, Randy, PTAL
3 years, 10 months ago (2017-02-15 12:05:53 UTC) #4
rnephew (Reviews Here)
3 years, 10 months ago (2017-02-15 15:04:09 UTC) #7 
https://codereview.chromium.org/2694403002/diff/1/tools/perf/fetch_benchmark_...
File tools/perf/fetch_benchmark_deps_unittest.py (right):

https://codereview.chromium.org/2694403002/diff/1/tools/perf/fetch_benchmark_...
tools/perf/fetch_benchmark_deps_unittest.py:49: '.DownloadArchivesIfNeeded') as
mock_download:
I am doing work to change over to a new version of archive_info. I think the
correct fix is to change this line to:

with mock.patch('telemetry.wpr.archive_info2.WprArchiveInfo'
                             '.DownloadArchivesIfNeeded') as mock_download:

When I move archive_info2 back to archive_info (when fully deleting the old
version) I will make sure to change this back.

Powered by Google App Engine
This is Rietveld 408576698