Normalize UriData.parse result.

Normalize UriData.parse result.

Validates base64 encoding, normalizes padding.
Normalizes non-base64 data using URI percent-escapes for all invalid characters.

Fixes issue #28728, #28700
BUG= http://dartbug.com/28728 http://dartbug.com/28700
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/dccdd1b981b88fa6996e964848fda7c83be1e3be

[Lasse Reichstein Nielsen, 2017-02-15 08:39:38]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-02-15 17:03:10]

LGTM.

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:73: * * Validate that the length is correct (a
multiplum of four).
multiple ?

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:92: originalChar = -1;
Add comment explaining that you pick '-1' because %25 would yield '%' as outcome
making char and originalChar seemingly similar.

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:97: char = 0;  // Invalid.
If this is invalid, why it is set to 0, and not `_Base64Decoder._invalid` ?

Alternatively why not just throw here?

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:172: "Invalid base64 padding, padded length must be
multiplum of four, "
multiple

https://codereview.chromium.org/2694373003/diff/20001/tests/corelib/data_uri_...
File tests/corelib/data_uri_test.dart (right):

https://codereview.chromium.org/2694373003/diff/20001/tests/corelib/data_uri_...
tests/corelib/data_uri_test.dart:25: testUriEquals("data:,abc?d%23e");  // #
must and will be is escaped.
-is-

[Lasse Reichstein Nielsen, 2017-02-17 10:02:42]

Description was changed from

==========
Normalize UriData.parse result.

Validates base64 encoding, normalizes padding.
Normalizes non-base64 data using URI percent-escapes for all invalid characters.

Fixes issue #28728, #28700
BUG= http://dartbug.com/28728 http://dartbug.com/28700
==========

to

==========
Normalize UriData.parse result.

Validates base64 encoding, normalizes padding.
Normalizes non-base64 data using URI percent-escapes for all invalid characters.

Fixes issue #28728, #28700
BUG= http://dartbug.com/28728 http://dartbug.com/28700
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dccdd1b981b88fa6996e964848fda7c83be1e3be
==========

[Lasse Reichstein Nielsen, 2017-02-17 10:02:44]

Committed patchset #3 (id:40001) manually as
dccdd1b981b88fa6996e964848fda7c83be1e3be (presubmit successful).

[Lasse Reichstein Nielsen, 2017-02-17 11:22:09]

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:73: * * Validate that the length is correct (a
multiplum of four).
On 2017/02/15 17:03:09, floitsch wrote:
> multiple ?

Done.

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:92: originalChar = -1;
It's actually not necessary to set it at all - a '%' isn't a valid character
anyway, so the only thing originalChar is compared to below is `=`, which it
isn't.

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:97: char = 0;  // Invalid.
I'll set it to -1, so it'll just fall through to the throw below without wasting
time in the valid-char checks below.
No need to duplicate that throw.

https://codereview.chromium.org/2694373003/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:172: "Invalid base64 padding, padded length must be
multiplum of four, "
On 2017/02/15 17:03:09, floitsch wrote:
> multiple

Done.