Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

Issue 2694293003: Simplify specifiers when all platforms are covered, and sort lines. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
index 3622121a8a01b0acd05e8f2f70f8ca241e94b53e..624de3eb58e524c5c1c20088393af2ba7fcc5b10 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
@@ -256,7 +256,7 @@ class WPTExpectationsUpdater(object):
['BUG_URL [PLATFORM(S)] TEST_NAME [EXPECTATION(S)]']
"""
line_list = []
- for test_name, port_results in merged_results.iteritems():
+ for test_name, port_results in sorted(merged_results.iteritems()):
for port_names in sorted(port_results):
if test_name.startswith('external'):
line_parts = [port_results[port_names]['bug']]
@@ -339,7 +339,7 @@ class WPTExpectationsUpdater(object):
if version_specifiers.issubset(specifiers):
specifiers -= version_specifiers
specifiers.add(macro_specifier)
- if specifiers == set(configuration_specifier_macros):
+ if specifiers == {macro.lower() for macro in configuration_specifier_macros.keys()}:
return []
return sorted(specifier.capitalize() for specifier in specifiers)

Powered by Google App Engine
This is Rietveld 408576698