Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2694283003: Annotate ScriptWrappable-embedding singletons.

Created:
3 years, 10 months ago by sof
Modified:
3 years, 8 months ago
Reviewers:
dglazkov
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dominicc+watchlist_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, f(malita), fs, gasubic, gyuyoung2, haraken, horo+watch_chromium.org, jchaffraix+rendering, kinuko+worker_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, Mikhail, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, shimazu+worker_chromium.org, nessy, Srirama, szager+layoutwatch_chromium.org, webcomponents-bugzilla_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Annotate ScriptWrappable-embedding singletons. R= BUG=688569

Patch Set 1 #

Patch Set 2 : add XPathValue singleton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/WeakIdentifierMap.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementScheduler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 1 5 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathValue.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSourceRegistry.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Allocator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
esprehn
I worry all of this isn't adding a lot of value. No one is going ...
3 years, 10 months ago (2017-02-14 22:19:27 UTC) #2
sof
3 years, 10 months ago (2017-02-15 06:26:08 UTC) #3 
On 2017/02/14 22:19:27, esprehn wrote:
> I worry all of this isn't adding a lot of value. No one is going to know
what's
> unsafe about them, and a bunch are empty immutable things...

I do too, but what are our alternatives?

 - finesse the static analysis to trigger less often.
 - keep these singletons per-context rather than global.
 - ignore singleton-reachable ScriptWrappables as posing a problem.

Other options?

Powered by Google App Engine
This is Rietveld 408576698