Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 2694213002: Revert "Improvements to causal async stack traces" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 734d14de97970b408b0885a86a2c4e74c8005ed5..e1f43af87aaf206766376a74a43ca944456440b5 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -8,6 +8,7 @@ import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'package:observatory/service_io.dart';
+import 'package:stack_trace/stack_trace.dart';
import 'service_test_common.dart';
/// Will be set to the http address of the VM's service protocol before
@@ -293,7 +294,7 @@ class _ServiceTesterRunner {
}
setupAddresses(serverAddress);
var name = Platform.script.pathSegments.last;
- try {
+ Chain.capture(() async {
var vm =
new WebSocketVM(new WebSocketVMTarget(serviceWebsocketAddress));
print('Loading VM...');
@@ -328,16 +329,16 @@ class _ServiceTesterRunner {
print('All service tests completed successfully.');
testsDone = true;
await process.requestExit();
- } catch (error, stackTrace) {
+ }, onError: (error, stackTrace) {
if (testsDone) {
print('Ignoring late exception during process exit:\n'
'$error\n#stackTrace');
} else {
process.requestExit();
print('Unexpected exception in service tests: $error\n$stackTrace');
- rethrow;
+ throw error;
}
- }
+ });
});
}
« no previous file with comments | « runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698