Issue 2694213002: Revert "Improvements to causal async stack traces"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2694213002: Revert "Improvements to causal async stack traces" (Closed)

Created:
3 years, 10 months ago by Cutch

Modified:
3 years, 10 months ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Improvements to causal async stack traces" This reverts commit 8538d81473d81e46d0bc8ea82607581ebff65390. BUG= Committed: https://github.com/dart-lang/sdk/commit/e84d8a1f11dd496fcad13e48ba3e48b788ed6494

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -192 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/tests/service/causal_async_stack_contents_test.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart	View	3 chunks	+14 lines, -10 lines	0 comments	Download
M	runtime/observatory/tests/service/test_helper.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+2 lines, -25 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tests/language/vm/causal_async_exception_stack2_test.dart	View	1 chunk	+0 lines, -98 lines	0 comments	Download
M	tests/language/vm/causal_async_exception_stack_test.dart	View	2 chunks	+5 lines, -39 lines	0 comments	Download

Total messages: 2 (1 generated)

Cutch

3 years, 10 months ago (2017-02-14 10:29:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e84d8a1f11dd496fcad13e48ba3e48b788ed6494 (presubmit successful).