Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 269413004: Add support for multiple zygote fork delegates (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Mark Seaborn
Visibility:
Public.

Description

Add support for multiple zygote fork delegates No functional changes yet, just preparation for splitting NaCl's fork delegate into two different implementations. BUG=364945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269673

Patch Set 1 #

Patch Set 2 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -67 lines) Patch
M chrome/app/chrome_main_delegate.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/app/content_main_runner.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/public/app/content_main_delegate.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/zygote_fork_delegate_linux.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/zygote/zygote_linux.h View 4 chunks +8 lines, -11 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 9 chunks +28 lines, -33 lines 0 comments Download
M content/zygote/zygote_main.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
mdempsky
Mostly just a matter of changing ZygoteForkDelegate* to ScopedVector<ZygoteForkDelegate> in a bunch of APIs; the ...
6 years, 7 months ago (2014-05-09 03:40:55 UTC) #1
jln (very slow on Chromium)
lgtm, as discussed in person this is a good starting point for fixing the linked-bug.
6 years, 7 months ago (2014-05-09 20:42:37 UTC) #2
mdempsky
piman: Please review changes to content/app and content/common for OWNERS approval. cpu: Please review tiny ...
6 years, 7 months ago (2014-05-09 21:08:59 UTC) #3
mdempsky
On 2014/05/09 21:08:59, mdempsky wrote: > piman: Please review changes to content/app and content/common for ...
6 years, 7 months ago (2014-05-09 21:10:52 UTC) #4
piman
lgtm
6 years, 7 months ago (2014-05-09 21:58:23 UTC) #5
cpu_(ooo_6.6-7.5)
rs lgtm
6 years, 7 months ago (2014-05-10 00:15:28 UTC) #6
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-10 01:00:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/269413004/20001
6 years, 7 months ago (2014-05-10 01:04:20 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 03:32:28 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 03:38:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66981)
6 years, 7 months ago (2014-05-10 03:38:32 UTC) #11
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-10 05:22:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/269413004/20001
6 years, 7 months ago (2014-05-10 05:24:14 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 05:29:51 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 05:33:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67000)
6 years, 7 months ago (2014-05-10 05:33:27 UTC) #16
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-10 06:39:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/269413004/20001
6 years, 7 months ago (2014-05-10 06:43:20 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:17:49 UTC) #19
Message was sent while issue was closed.
Change committed as 269673

Powered by Google App Engine
This is Rietveld 408576698