Support saving a web page as a plain HTML

Support saving a web page as a plain HTML

Merge ShouldSaveAsMHTML() branch and can_save_as_complete_ branch.

BUG=369875
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270640

[asanka, 2014-05-13 18:32:34]

LGTM and sorry about the delay.

https://codereview.chromium.org/269413002/diff/30001/chrome/browser/download/...
File chrome/browser/download/save_package_file_picker.cc (right):

https://codereview.chromium.org/269413002/diff/30001/chrome/browser/download/...
chrome/browser/download/save_package_file_picker.cc:248: // Use something other
than UNKNOWN to avoid DCHECK failure later.
Which DCHECK and can the DCHECK be fixed instead?

[hashimoto, 2014-05-14 03:49:09]

Thank you for reviewing!

https://codereview.chromium.org/269413002/diff/30001/chrome/browser/download/...
File chrome/browser/download/save_package_file_picker.cc (right):

https://codereview.chromium.org/269413002/diff/30001/chrome/browser/download/...
chrome/browser/download/save_package_file_picker.cc:248: // Use something other
than UNKNOWN to avoid DCHECK failure later.
On 2014/05/13 18:32:34, asanka wrote:
> Which DCHECK and can the DCHECK be fixed instead?

Many DCHECKs in content/browser/download/save_package.cc are requiring
type!=UNKNOWN.
Maybe the right fix is to stop using SavePackage when
can_save_as_complete_==false? (it will be processed as a normal download
anyways.)

Fixed the wording of the comment.

[hashimoto, 2014-05-14 05:06:04]

Made another change to generated_resources.grd to fix chrome://flags text.

browser_tests was failing because the default preference value is "HTML
Complete".
Fixed it by overriding the pref when MHTML is enabled.

PTAL

[asanka, 2014-05-14 19:12:11]

LGTM

[hashimoto, 2014-05-15 04:22:49]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-05-15 04:23:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/269413002/90001

[commit-bot: I haz the power, 2014-05-15 06:05:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-15 08:32:38]

Change committed as 270640