Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Unified Diff: runtime/bin/extensions_win.cc

Issue 2694103004: Cleanup app snapshots on isolate/vm exit. (Closed)
Patch Set: merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/extensions_macos.cc ('k') | runtime/bin/file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions_win.cc
diff --git a/runtime/bin/extensions_win.cc b/runtime/bin/extensions_win.cc
index b07bf590130301506211d8c8264b7b9fe1696019..9bb7d2a04d85e9f39bf89dfca7da97b0592d0c03 100644
--- a/runtime/bin/extensions_win.cc
+++ b/runtime/bin/extensions_win.cc
@@ -8,6 +8,7 @@
#include "bin/extensions.h"
#include "bin/utils.h"
#include "bin/utils_win.h"
+#include "platform/assert.h"
namespace dart {
namespace bin {
@@ -18,7 +19,7 @@ const char* kIsolateSnapshotDataSymbolName = "_kDartIsolateSnapshotData";
const char* kIsolateSnapshotInstructionsSymbolName =
"_kDartIsolateSnapshotInstructions";
-void* Extensions::LoadExtensionLibrary(const char* library_file) {
+void* Extensions::LoadLibrary(const char* library_file) {
SetLastError(0);
// Convert to wchar_t string.
@@ -32,11 +33,20 @@ void* Extensions::LoadExtensionLibrary(const char* library_file) {
return ext;
}
+
void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {
SetLastError(0);
return GetProcAddress(reinterpret_cast<HMODULE>(lib_handle), symbol);
}
+
+void Extensions::UnloadLibrary(void* lib_handle) {
+ SetLastError(0);
+ BOOL result = FreeLibrary(reinterpret_cast<HMODULE>(lib_handle));
+ ASSERT(result);
+}
+
+
Dart_Handle Extensions::GetError() {
int last_error = GetLastError();
if (last_error != 0) {
« no previous file with comments | « runtime/bin/extensions_macos.cc ('k') | runtime/bin/file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698