Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2694103002: Create OptionalShareTargetsManager (Closed)
Patch Set: Fixing Teds comments 1 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index ff97c0d5a2e30d0e3360285fbf0184c364026ead..200513068c29fbd52ec453ebd4aa3ea3b5b023e7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -102,6 +102,7 @@ import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.printing.PrintShareActivity;
import org.chromium.chrome.browser.printing.TabPrinter;
+import org.chromium.chrome.browser.share.OptionalShareTargetsManager;
import org.chromium.chrome.browser.share.ShareHelper;
import org.chromium.chrome.browser.snackbar.BottomContainer;
import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
@@ -1148,15 +1149,16 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
final Tab currentTab = getActivityTab();
if (currentTab == null) return;
- PrintingController printingController = PrintingControllerImpl.getInstance();
- if (printingController != null && !currentTab.isNativePage() && !printingController.isBusy()
- && PrefServiceBridge.getInstance().isPrintingEnabled()) {
- PrintShareActivity.enablePrintShareOption(this, new Runnable() {
- @Override
- public void run() {
- triggerShare(currentTab, shareDirectly, isIncognito);
- }
- });
+ if (PrintShareActivity.printingIsEnabled(currentTab)) {
+ List<Class<? extends Activity>> classesToEnable = new ArrayList<>(1);
+ classesToEnable.add(PrintShareActivity.class);
+ OptionalShareTargetsManager.enableOptionalShareActivities(
+ this, classesToEnable, new Runnable() {
+ @Override
+ public void run() {
+ triggerShare(currentTab, shareDirectly, isIncognito);
+ }
+ });
return;
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698