Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

Issue 2694083005: memory-infra: Finish moving memory_infra from TracingController (Closed)
Patch Set: review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
index 1bc8254b90282a01e301422f3c558b2c944cde85..0a9284d96767a628de5c56bbd748041187d67e5c 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
@@ -21,13 +21,17 @@ class CoordinatorImplTest : public testing::Test {
CoordinatorImplTest() {}
void SetUp() override {
dump_response_args_ = {static_cast<uint64_t>(-1), false};
+ coordinator_.reset(new CoordinatorImpl());
+ coordinator_->InitializeForTest(base::ThreadTaskRunnerHandle::Get().get());
}
+ void TearDown() override { coordinator_.reset(); }
+
void RegisterProcessLocalDumpManager(
mojom::ProcessLocalDumpManagerPtr process_manager) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&CoordinatorImpl::RegisterProcessLocalDumpManager,
- base::Unretained(&coordinator_),
+ base::Unretained(coordinator_.get()),
base::Passed(&process_manager)));
}
@@ -36,7 +40,7 @@ class CoordinatorImplTest : public testing::Test {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(&CoordinatorImpl::RequestGlobalMemoryDump,
- base::Unretained(&coordinator_), args,
+ base::Unretained(coordinator_.get()), args,
base::Bind(&CoordinatorImplTest::OnGlobalMemoryDumpResponse,
base::Unretained(this), closure)));
}
@@ -57,7 +61,7 @@ class CoordinatorImplTest : public testing::Test {
DumpResponseArgs dump_response_args_;
private:
- CoordinatorImpl coordinator_;
+ std::unique_ptr<CoordinatorImpl> coordinator_;
base::MessageLoop message_loop_;
};

Powered by Google App Engine
This is Rietveld 408576698