Index: base/trace_event/memory_dump_manager.cc |
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc |
index ebc22503ab146961ad69566d8b36af77be77b0bb..618f63a6de35ee73d77936d090a673797fcb3177 100644 |
--- a/base/trace_event/memory_dump_manager.cc |
+++ b/base/trace_event/memory_dump_manager.cc |
@@ -153,9 +153,7 @@ void MemoryDumpManager::SetInstanceForTesting(MemoryDumpManager* instance) { |
} |
MemoryDumpManager::MemoryDumpManager() |
- : delegate_(nullptr), |
- is_coordinator_(false), |
- memory_tracing_enabled_(0), |
+ : memory_tracing_enabled_(0), |
tracing_process_id_(kInvalidTracingProcessId), |
dumper_registrations_ignored_for_testing_(false), |
heap_profiling_enabled_(false) { |
@@ -212,14 +210,13 @@ void MemoryDumpManager::EnableHeapProfilingIfNeeded() { |
heap_profiling_enabled_ = true; |
} |
-void MemoryDumpManager::Initialize(MemoryDumpManagerDelegate* delegate, |
- bool is_coordinator) { |
+void MemoryDumpManager::Initialize( |
+ std::unique_ptr<MemoryDumpManagerDelegate> delegate) { |
{ |
AutoLock lock(lock_); |
DCHECK(delegate); |
DCHECK(!delegate_); |
- delegate_ = delegate; |
- is_coordinator_ = is_coordinator; |
+ delegate_.swap(delegate); |
Primiano Tucci (use gerrit)
2017/02/17 19:08:44
As commented above I think this doesn't need to be
chiniforooshan
2017/02/22 05:16:34
Done.
|
EnableHeapProfilingIfNeeded(); |
} |
@@ -450,21 +447,10 @@ void MemoryDumpManager::RequestGlobalDump( |
TRACE_ID_MANGLE(guid)); |
MemoryDumpCallback wrapped_callback = Bind(&OnGlobalDumpDone, callback); |
- // Technically there is no need to grab the |lock_| here as the delegate is |
- // long-lived and can only be set by Initialize(), which is locked and |
- // necessarily happens before memory_tracing_enabled_ == true. |
- // Not taking the |lock_|, though, is lakely make TSan barf and, at this point |
- // (memory-infra is enabled) we're not in the fast-path anymore. |
- MemoryDumpManagerDelegate* delegate; |
- { |
- AutoLock lock(lock_); |
- delegate = delegate_; |
- } |
- |
// The delegate will coordinate the IPC broadcast and at some point invoke |
// CreateProcessDump() to get a dump for the current process. |
MemoryDumpRequestArgs args = {guid, dump_type, level_of_detail}; |
- delegate->RequestGlobalMemoryDump(args, wrapped_callback); |
+ delegate_->RequestGlobalMemoryDump(args, wrapped_callback); |
} |
void MemoryDumpManager::RequestGlobalDump( |
@@ -810,7 +796,7 @@ void MemoryDumpManager::OnTraceLogEnabled() { |
subtle::NoBarrier_Store(&memory_tracing_enabled_, 1); |
- if (!is_coordinator_) |
+ if (!delegate_->IsCoordinator()) |
return; |
} |
@@ -856,10 +842,6 @@ bool MemoryDumpManager::IsDumpModeAllowed(MemoryDumpLevelOfDetail dump_mode) { |
dump_mode) != 0; |
} |
-uint64_t MemoryDumpManager::GetTracingProcessId() const { |
- return delegate_->GetTracingProcessId(); |
-} |
- |
MemoryDumpManager::MemoryDumpProviderInfo::MemoryDumpProviderInfo( |
MemoryDumpProvider* dump_provider, |
const char* name, |