Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: android_webview/common/crash_reporter/crash_keys.cc

Issue 2694083004: Fix minidump-generation for debug builds. (Closed)
Patch Set: Only declare + use SanitizationInfo on Android. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/common/crash_reporter/crash_keys.cc
diff --git a/android_webview/common/crash_reporter/crash_keys.cc b/android_webview/common/crash_reporter/crash_keys.cc
index cd82afc34bb68a402c48d870c89d9344f8e29f08..8239e2d268f739daa26863e2c0de506edfbb574d 100644
--- a/android_webview/common/crash_reporter/crash_keys.cc
+++ b/android_webview/common/crash_reporter/crash_keys.cc
@@ -12,6 +12,8 @@ using namespace crash_keys;
namespace android_webview {
namespace crash_keys {
+const char kActiveURL[] = "url-chunk";
+
const char kGPUDriverVersion[] = "gpu-driver";
const char kGPUPixelShaderVersion[] = "gpu-psver";
const char kGPUVertexShaderVersion[] = "gpu-vsver";
@@ -20,18 +22,90 @@ const char kGPURenderer[] = "gpu-gl-renderer";
size_t RegisterWebViewCrashKeys() {
base::debug::CrashKey fixed_keys[] = {
- { kGPUDriverVersion, kSmallSize },
- { kGPUPixelShaderVersion, kSmallSize },
- { kGPUVertexShaderVersion, kSmallSize },
- { kGPUVendor, kSmallSize },
- { kGPURenderer, kSmallSize },
-
- // content/:
- { "bad_message_reason", kSmallSize },
- { "discardable-memory-allocated", kSmallSize },
- { "discardable-memory-free", kSmallSize },
- { "mojo-message-error", kMediumSize },
- { "total-discardable-memory-allocated", kSmallSize },
+ {kActiveURL, kLargeSize},
+ {kGPUDriverVersion, kSmallSize},
+ {kGPUPixelShaderVersion, kSmallSize},
+ {kGPUVertexShaderVersion, kSmallSize},
+ {kGPUVendor, kSmallSize},
+ {kGPURenderer, kSmallSize},
+
+ // TODO some of the crash keys are never used. E.g. kBug464926CrashKey
+
+ // content/:
+ {"bad_message_reason", kSmallSize},
+ {"discardable-memory-allocated", kSmallSize},
+ {"discardable-memory-free", kSmallSize},
+ {"mojo-message-error", kMediumSize},
+ {"ppapi_path", kMediumSize},
+ {"subresource_url", kLargeSize},
+ {"total-discardable-memory-allocated", kSmallSize},
+
+ // gin/:
+ {"v8-ignition", kSmallSize},
+
+ // TODO is this needed?
+ // sandbox/:
+ {"seccomp-sigsys", kMediumSize},
+
+ // Temporary for http://crbug.com/575245.
+ {"swapout_frame_id", kSmallSize},
+ {"swapout_proxy_id", kSmallSize},
+ {"swapout_view_id", kSmallSize},
+ {"commit_frame_id", kSmallSize},
+ {"commit_proxy_id", kSmallSize},
+ {"commit_view_id", kSmallSize},
+ {"commit_main_render_frame_id", kSmallSize},
+ {"newproxy_proxy_id", kSmallSize},
+ {"newproxy_view_id", kSmallSize},
+ {"newproxy_opener_id", kSmallSize},
+ {"newproxy_parent_id", kSmallSize},
+ {"rvinit_view_id", kSmallSize},
+ {"rvinit_proxy_id", kSmallSize},
+ {"rvinit_main_frame_id", kSmallSize},
+ {"initrf_frame_id", kSmallSize},
+ {"initrf_proxy_id", kSmallSize},
+ {"initrf_view_id", kSmallSize},
+ {"initrf_main_frame_id", kSmallSize},
+ {"initrf_view_is_live", kSmallSize},
+
+ // Temporary for https://crbug.com/591478.
+ {"initrf_parent_proxy_exists", kSmallSize},
+ {"initrf_render_view_is_live", kSmallSize},
+ {"initrf_parent_is_in_same_site_instance", kSmallSize},
+ {"initrf_parent_process_is_live", kSmallSize},
+ {"initrf_root_is_in_same_site_instance", kSmallSize},
+ {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
+ {"initrf_root_process_is_live", kSmallSize},
+ {"initrf_root_proxy_is_live", kSmallSize},
+
+ // Temporary for https://crbug.com/626802.
+ {"newframe_routing_id", kSmallSize},
+ {"newframe_proxy_id", kSmallSize},
+ {"newframe_opener_id", kSmallSize},
+ {"newframe_parent_id", kSmallSize},
+ {"newframe_widget_id", kSmallSize},
+ {"newframe_widget_hidden", kSmallSize},
+ {"newframe_replicated_origin", kSmallSize},
+ {"newframe_oopifs_possible", kSmallSize},
+
+ // Temporary for https://crbug.com/630103.
+ {"origin_mismatch_url", kLargeSize},
+ {"origin_mismatch_origin", kMediumSize},
+ {"origin_mismatch_transition", kSmallSize},
+ {"origin_mismatch_redirects", kSmallSize},
+ {"origin_mismatch_same_page", kSmallSize},
+
+ // Temporary for https://crbug.com/612711.
+ {"aci_wrong_sp_extension_id", kSmallSize},
+
+ // Temporary for https://crbug.com/616149.
+ {"existing_extension_pref_value_type", kSmallSize},
+
+ // Temporary for https://crbug.com/668633.
+ {"swdh_set_hosted_version_worker_pid", kSmallSize},
+ {"swdh_set_hosted_version_host_pid", kSmallSize},
+ {"swdh_set_hosted_version_is_new_process", kSmallSize},
+ {"swdh_set_hosted_version_restart_count", kSmallSize},
};
std::vector<base::debug::CrashKey> keys(fixed_keys,

Powered by Google App Engine
This is Rietveld 408576698