Chromium Code Reviews| Index: components/crash/content/app/breakpad_linux.h |
| diff --git a/components/crash/content/app/breakpad_linux.h b/components/crash/content/app/breakpad_linux.h |
| index 2cd1795831af5b2be7556be40513fb9ed2fe946a..35ebcdadbdcd77a832753d71fe6b9ffc1be86750 100644 |
| --- a/components/crash/content/app/breakpad_linux.h |
| +++ b/components/crash/content/app/breakpad_linux.h |
| @@ -16,7 +16,15 @@ namespace breakpad { |
| // Turns on the crash reporter in any process. |
| extern void InitCrashReporter(const std::string& process_type); |
| +struct SanitizationInfo { |
|
Torne
2017/02/15 11:45:13
Can this go inside the OS_ANDROID block, or is it
gsennton
2017/02/15 17:26:42
Done.
|
| + bool should_sanitize_dumps; |
| + bool skip_dump_if_principal_mapping_not_referenced; |
| + uintptr_t address_within_principal_mapping; |
| +}; |
| + |
| #if defined(OS_ANDROID) |
| +extern void InitCrashReporter(const std::string& process_type, |
| + const SanitizationInfo& sanitizationInfo); |
| const char kWebViewSingleProcessType[] = "webview"; |
| const char kBrowserProcessType[] = "browser"; |
| @@ -24,10 +32,15 @@ const char kBrowserProcessType[] = "browser"; |
| // Enables the crash reporter in child processes. |
| extern void InitNonBrowserCrashReporterForAndroid( |
| const std::string& process_type); |
| +// Enables the crash reporter in child processes. |
| +extern void InitNonBrowserCrashReporterForAndroid( |
| + const std::string& process_type, |
| + const SanitizationInfo& sanitizationInfo); |
| // Enables *micro*dump only. Can be called from any process. |
| extern void InitMicrodumpCrashHandlerIfNecessary( |
| - const std::string& process_type); |
| + const std::string& process_type, |
| + const SanitizationInfo& sanitizationInfo); |
| extern void AddGpuFingerprintToMicrodumpCrashHandler( |
| const std::string& gpu_fingerprint); |
| @@ -36,22 +49,6 @@ extern void AddGpuFingerprintToMicrodumpCrashHandler( |
| // generate dumps. Calling base::debug::DumpWithoutCrashing will still |
| // generate a dump. |
| extern void SuppressDumpGeneration(); |
| - |
| -// Calling SetShouldSanitizeDumps determines whether or not subsequent |
| -// crash dumps should be sanitized. Sanitized dumps still contain |
| -// enough stack information to unwind crashes, but other stack data is |
| -// erased. |
| -extern void SetShouldSanitizeDumps(bool sanitize_dumps); |
| - |
| -// Inform breakpad of an address within the text section that is |
| -// considered interesting for the purpose of crashes so that this can |
| -// be used to elide microdumps that do not reference interesting |
| -// code. Minidumps will still be generated, but stacks from threads |
| -// that do not reference the principal mapping will not be included. |
| -// The full interesting address range is determined by looking up the |
| -// memory mapping that contains |addr|. |
| -extern void SetSkipDumpIfPrincipalMappingNotReferenced( |
| - uintptr_t address_within_principal_mapping); |
| #endif |
| // Checks if crash reporting is enabled. Note that this is not the same as |