Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: chrome/common/crash_keys.cc

Issue 2694083004: Fix minidump-generation for debug builds. (Closed)
Patch Set: Remove globals only used at init. Remove UpdateMicrodump[ExceptionHandler|Descriptor] methods. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index e57c9a806903ede90b843b1f7c359bd6b59f1f9a..99b7f4a126255e527d2c439f2b0f73751f720121 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -103,7 +103,10 @@ size_t RegisterChromeCrashKeys() {
// but ultimately constitute a single key-value pair.
//
// If you're adding keys here, please also add them to the following list:
- // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper().
+ // chrome/app/chrome_crash_reporter_client_win.cc::RegisterCrashKeysHelper(),
+ // and consider adding the new keys to the following list as well:
+ // android_webview/common/crash_reporter/crash_keys.cc::
+ // RegisterWebViewCrashKeys().
base::debug::CrashKey fixed_keys[] = {
#if defined(OS_MACOSX) || defined(OS_WIN)
{ kMetricsClientId, kSmallSize },

Powered by Google App Engine
This is Rietveld 408576698