Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2694083002: Switch to the new analysis driver in analyzer_cli. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to the new analysis driver in analyzer_cli. Our internal users use the new analysis driver, and we're enabling it for everyone in 1.23, AFAIK. We disable using the file system byte store during internal testing because we don't want accidentally change analyzer code, run tests and get all green only because we forgot to update DATA_VERSION. R=brianwilkerson@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cda7520e5c19425637351be5eae04af7e3136111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 5 chunks +26 lines, -16 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 4 chunks +12 lines, -2 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-13 21:29:21 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-13 21:31:57 UTC) #2
scheglov
3 years, 10 months ago (2017-02-14 17:04:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cda7520e5c19425637351be5eae04af7e3136111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698