third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html - Issue 2694043004: Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be ba…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html

Issue 2694043004: Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be ba… (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/selection/selectAllChildren-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure-expected.txt » ('j') | third_party/WebKit/Source/core/editing/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html

diff --git a/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html b/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html

index c1b1eb8d52a52849fc72b2d68e01f42ec604167d..0d47ee16c59fe74d085bb9d2ecbd8f5af95c84a0 100644

--- a/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html

+++ b/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html

@@ -50,7 +50,7 @@ shouldBe("getSelection().baseNode", "container");

shouldBe("getSelection().baseOffset", "1");

shouldBe("getSelection().extentNode", "container");

shouldBe("getSelection().extentOffset", "1");

-shouldBe("getSelection().type", "'Range'");

+shouldBe("getSelection().type", "'Caret'");

yosin_UTC9 2017/02/14 04:52:21 Nice, finally, we get correct value of Selection#t

debug("\nAdd a textarea element.\n");

@@ -75,7 +75,7 @@ shouldBe("getSelection().baseNode", "container");

shouldBe("getSelection().baseOffset", "2");

shouldBe("getSelection().extentNode", "container");

shouldBe("getSelection().extentOffset", "2");

-shouldBe("getSelection().type", "'Range'");

+shouldBe("getSelection().type", "'Caret'");

document.body.removeChild(container);