Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.h

Issue 2694043004: Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be ba… (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/DOMSelection.h
diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.h b/third_party/WebKit/Source/core/editing/DOMSelection.h
index fa2cf7e9e7abc97637ba4692f5d6b3a895c3a6f3..9723ea4e4df7d0bf3a62e8d091f3463d1c64d6a8 100644
--- a/third_party/WebKit/Source/core/editing/DOMSelection.h
+++ b/third_party/WebKit/Source/core/editing/DOMSelection.h
@@ -89,7 +89,7 @@ class CORE_EXPORT DOMSelection final : public GarbageCollected<DOMSelection>,
void collapseToEnd(ExceptionState&);
void collapseToStart(ExceptionState&);
void extend(Node*, int offset, ExceptionState&);
- Range* getRangeAt(int, ExceptionState&);
+ Range* getRangeAt(int, ExceptionState&) const;
void removeAllRanges();
void addRange(Range*);
void deleteFromDocument();
@@ -117,11 +117,11 @@ class CORE_EXPORT DOMSelection final : public GarbageCollected<DOMSelection>,
bool isValidForPosition(Node*) const;
void addConsoleError(const String& message);
-
- Range* createRangeFromSelectionEditor();
+ Range* primaryRangeOrNull() const;
+ Range* createRangeFromSelectionEditor() const;
bool isSelectionOfDocument() const;
- void cacheRangeIfSelectionOfDocument(Range*);
+ void cacheRangeIfSelectionOfDocument(Range*) const;
Range* documentCachedRange() const;
void clearCachedRangeIfSelectionOfDocument();

Powered by Google App Engine
This is Rietveld 408576698