Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2694023003: Make CanvasPainter raster directly to an SkBitmap (Closed)
Patch Set: tapted review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/label_unittest.cc ('k') | ui/views/drag_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index c9987ca6331d2b1b83eb0dec90978aea00a7dd30..4e848c1717beba64ad225ec0582ec434ffb47d5a 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -1063,16 +1063,21 @@ void Textfield::WriteDragDataForView(View* sender,
display::Screen::GetScreen()->GetDisplayNearestWindow(native_view);
size.SetToMin(gfx::Size(display.size().width(), height()));
label.SetBoundsRect(gfx::Rect(size));
- std::unique_ptr<gfx::Canvas> canvas(
- GetCanvasForDragImage(GetWidget(), label.size()));
label.SetEnabledColor(GetTextColor());
+
+ SkBitmap bitmap;
+ float raster_scale = ScaleFactorForDragFromWidget(GetWidget());
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
// Desktop Linux Aura does not yet support transparency in drag images.
- canvas->DrawColor(GetBackgroundColor());
+ SkColor color = GetBackgroundColor();
+#else
+ SkColor color = SK_ColorTRANSPARENT;
#endif
- label.Paint(ui::CanvasPainter(canvas.get(), 1.f).context());
+ label.Paint(
+ ui::CanvasPainter(&bitmap, label.size(), raster_scale, color).context());
const gfx::Vector2d kOffset(-15, 0);
- drag_utils::SetDragImageOnDataObject(*canvas, kOffset, data);
+ gfx::ImageSkia image(gfx::ImageSkiaRep(bitmap, raster_scale));
+ drag_utils::SetDragImageOnDataObject(image, kOffset, data);
if (controller_)
controller_->OnWriteDragData(data);
}
« no previous file with comments | « ui/views/controls/label_unittest.cc ('k') | ui/views/drag_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698