ui/views/cocoa/bridged_content_view.mm - Issue 2694023003: Make CanvasPainter raster directly to an SkBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2694023003: Make CanvasPainter raster directly to an SkBitmap (Closed)

Patch Set: tapted review Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_content_view.mm

diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm

index 1796fff92a576f87b724a6acb8d6182c27da72b9..e4da0e0ad5a5eb1b3a7d66d59ec5153e84996ce4 100644

--- a/ui/views/cocoa/bridged_content_view.mm

+++ b/ui/views/cocoa/bridged_content_view.mm

@@ -732,9 +732,8 @@ ui::TextEditCommand GetTextEditCommandForMenuAction(SEL action) {

if (hostedView_->GetWidget()->GetLayer())

return;

- gfx::CanvasSkiaPaint canvas(dirtyRect, false /* opaque */);

- hostedView_->GetWidget()->OnNativeWidgetPaint(

- ui::CanvasPainter(&canvas, 1.f).context());

+ // TODO(tapted): Add a NOTREACHED() here. At the moment, low-level

+ // BridgedNativeWidget unit tests may not have a ui::Layer.

}

- (BOOL)isOpaque {

« no previous file with comments | « ui/views/button_drag_utils.cc ('k') | ui/views/controls/label_unittest.cc » ('j') | no next file with comments »