Make CanvasPainter raster directly to an SkBitmap

ui/views/drag_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/drag_utils.h"
 
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/views/widget/widget.h"
 
-namespace {
+namespace views {
 
 float GetDeviceScaleForNativeView(views::Widget* widget) {

[tapted, 2017/02/14 23:34:07]

nit: reorder to match .h  (and remove views:: prefix from Widget)

[enne (OOO), 2017/02/15 00:02:05]

You might want to consider a presubmit like
https://cs.chromium.org/chromium/src/cc/PRESUBMIT.py?q=cc/PRES+package:%5Echr...

[tapted, 2017/02/15 00:41:23]

ooh - indeed :) also for gfx::.. just came up in another review

   float device_scale = 1.0f;
   if (widget && widget->GetNativeView()) {
     gfx::NativeView view = widget->GetNativeView();
     display::Display display =
         display::Screen::GetScreen()->GetDisplayNearestWindow(view);
     device_scale = display.device_scale_factor();
   }
   return device_scale;
 }

[tapted, 2017/02/14 23:34:07]

random orthogonal thought: I wonder if we should have something like
display::Screen::GetMaxDisplayScaleFactor() -- i.e. return the device_scale from
the Display with the highest scale factor. Since presumably you could always
drag this asset to that display, and it would look a bit rubbish if it was drawn
at a smaller scale. (maybe even this method could just always return 2.0f
without breaking anything..).

[enne (OOO), 2017/02/15 00:02:05]

Yeah, that would make a lot of sense.  You could still get color space wrong,
but at least it wouldn't be fuzzy.

 
-}  // namespace
-
-namespace views {
-
 gfx::Canvas* GetCanvasForDragImage(views::Widget* widget,
                                    const gfx::Size& canvas_size) {
   float device_scale = GetDeviceScaleForNativeView(widget);
   return new gfx::Canvas(canvas_size, device_scale, false);
 }
 
 }  // namespace views