third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2694013005: Cleanup blink-side PlzNavigate logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2694013005: Cleanup blink-side PlzNavigate logic (Closed)

Patch Set: Move most of the placeholder handling to startLoad() Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 75d3864d39fc5bd556736709e9f0dde073e3fd17..8041af289d9aa162f293c0b4992e296bf6a18220 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -2047,8 +2047,7 @@ bool WebLocalFrameImpl::maybeRenderFallbackContent(

return false;

FrameLoader& frameloader = frame()->loader();

- frameloader.clearNavigationHandledByClient();

- frameloader.loadFailed(frameloader.documentLoader(), error);

+ frameloader.loadFailed(frameloader.provisionalDocumentLoader(), error);

return true;

}