Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2694013005: Cleanup blink-side PlzNavigate logic (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2029 matching lines...) Expand 10 before | Expand all | Expand 10 after
2040 } 2040 }
2041 2041
2042 bool WebLocalFrameImpl::maybeRenderFallbackContent( 2042 bool WebLocalFrameImpl::maybeRenderFallbackContent(
2043 const WebURLError& error) const { 2043 const WebURLError& error) const {
2044 DCHECK(frame()); 2044 DCHECK(frame());
2045 2045
2046 if (!frame()->owner() || !frame()->owner()->canRenderFallbackContent()) 2046 if (!frame()->owner() || !frame()->owner()->canRenderFallbackContent())
2047 return false; 2047 return false;
2048 2048
2049 FrameLoader& frameloader = frame()->loader(); 2049 FrameLoader& frameloader = frame()->loader();
2050 frameloader.clearNavigationHandledByClient(); 2050 frameloader.loadFailed(frameloader.provisionalDocumentLoader(), error);
ananta 2017/03/01 23:13:17 Is provisionalDocumentLoader() guaranteed to be no
Nate Chapin 2017/03/01 23:37:46 Done.
2051 frameloader.loadFailed(frameloader.documentLoader(), error);
2052 return true; 2051 return true;
2053 } 2052 }
2054 2053
2055 bool WebLocalFrameImpl::isLoading() const { 2054 bool WebLocalFrameImpl::isLoading() const {
2056 if (!frame() || !frame()->document()) 2055 if (!frame() || !frame()->document())
2057 return false; 2056 return false;
2058 return frame()->loader().stateMachine()->isDisplayingInitialEmptyDocument() || 2057 return frame()->loader().stateMachine()->isDisplayingInitialEmptyDocument() ||
2059 frame()->loader().hasProvisionalNavigation() || 2058 frame()->loader().hasProvisionalNavigation() ||
2060 !frame()->document()->loadEventFinished(); 2059 !frame()->document()->loadEventFinished();
2061 } 2060 }
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
2438 createMarkup(startPosition, endPosition, AnnotateForInterchange, 2437 createMarkup(startPosition, endPosition, AnnotateForInterchange,
2439 ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs); 2438 ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
2440 } else { 2439 } else {
2441 clipHtml = 2440 clipHtml =
2442 createMarkup(endPosition, startPosition, AnnotateForInterchange, 2441 createMarkup(endPosition, startPosition, AnnotateForInterchange,
2443 ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs); 2442 ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
2444 } 2443 }
2445 } 2444 }
2446 2445
2447 } // namespace blink 2446 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698