Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/loader/DocumentLoader.h

Issue 2694013005: Cleanup blink-side PlzNavigate logic (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 return m_replacesCurrentHistoryItem; 127 return m_replacesCurrentHistoryItem;
128 } 128 }
129 void setReplacesCurrentHistoryItem(bool replacesCurrentHistoryItem) { 129 void setReplacesCurrentHistoryItem(bool replacesCurrentHistoryItem) {
130 m_replacesCurrentHistoryItem = replacesCurrentHistoryItem; 130 m_replacesCurrentHistoryItem = replacesCurrentHistoryItem;
131 } 131 }
132 132
133 bool isCommittedButEmpty() const { 133 bool isCommittedButEmpty() const {
134 return m_state >= Committed && !m_dataReceived; 134 return m_state >= Committed && !m_dataReceived;
135 } 135 }
136 136
137 // Without PlzNavigate, this is only true for a narrow window during
138 // navigation start. For PlzNavigate, a navigation sent to the browser will
139 // leave a dummy DocumentLoader in the NotStarted state until the navigation
140 // actually handled in the renderer.
ananta 2017/03/01 23:13:17 Please rephrase to navigation is actually?
Nate Chapin 2017/03/01 23:37:46 Done.
141 bool didStart() const { return m_state != NotStarted; }
142
137 void setSentDidFinishLoad() { m_state = SentDidFinishLoad; } 143 void setSentDidFinishLoad() { m_state = SentDidFinishLoad; }
138 bool sentDidFinishLoad() const { return m_state == SentDidFinishLoad; } 144 bool sentDidFinishLoad() const { return m_state == SentDidFinishLoad; }
139 145
140 FrameLoadType loadType() const { return m_loadType; } 146 FrameLoadType loadType() const { return m_loadType; }
141 void setLoadType(FrameLoadType loadType) { m_loadType = loadType; } 147 void setLoadType(FrameLoadType loadType) { m_loadType = loadType; }
142 148
143 NavigationType getNavigationType() const { return m_navigationType; } 149 NavigationType getNavigationType() const { return m_navigationType; }
144 void setNavigationType(NavigationType navigationType) { 150 void setNavigationType(NavigationType navigationType) {
145 m_navigationType = navigationType; 151 m_navigationType = navigationType;
146 } 152 }
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 // Used to protect against reentrancy into dataReceived(). 299 // Used to protect against reentrancy into dataReceived().
294 bool m_inDataReceived; 300 bool m_inDataReceived;
295 RefPtr<SharedBuffer> m_dataBuffer; 301 RefPtr<SharedBuffer> m_dataBuffer;
296 }; 302 };
297 303
298 DECLARE_WEAK_IDENTIFIER_MAP(DocumentLoader); 304 DECLARE_WEAK_IDENTIFIER_MAP(DocumentLoader);
299 305
300 } // namespace blink 306 } // namespace blink
301 307
302 #endif // DocumentLoader_h 308 #endif // DocumentLoader_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698